Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): add grpc ext to docs container #6595

Merged
merged 6 commits into from Apr 30, 2024
Merged

fix(dev): add grpc ext to docs container #6595

merged 6 commits into from Apr 30, 2024

Conversation

bshaffer
Copy link
Contributor

Since the merging of #6454, the docs job has occasionally failed due to the grpc extension not being installed in the container. This was previously not necessary, as composer was not being run in the components, just in the dev directory (which does not require grpc)

Luckily this does not actually fail the job, only the storing of artifacts in placer.

cc @diptanshumittal

@bshaffer bshaffer added the next release PRs to be included in the next release label Apr 30, 2024
@bshaffer bshaffer marked this pull request as ready for review April 30, 2024 17:38
@bshaffer bshaffer requested review from a team as code owners April 30, 2024 17:38
Copy link

@Hectorhammett Hectorhammett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward to me 👍.

@bshaffer
Copy link
Contributor Author

This should be updated automatically because of the following configuration, although this will be the first time we have tested it:

# It will upload the docker image after successful builds.
env_vars: {
key: "TRAMPOLINE_IMAGE_UPLOAD"
value: "true"
}
# It will always build the docker image.
env_vars: {
key: "TRAMPOLINE_DOCKERFILE"
value: ".kokoro/docs/docker/Dockerfile"
}

@bshaffer bshaffer merged commit d590f0e into main Apr 30, 2024
24 checks passed
@bshaffer bshaffer deleted the fix-docs-job branch April 30, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release PRs to be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants