Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): rename see Google to see \Google #6647

Merged
merged 1 commit into from Sep 25, 2023
Merged

chore(docs): rename see Google to see \Google #6647

merged 1 commit into from Sep 25, 2023

Conversation

vishwarajanand
Copy link
Contributor

A way to address #6626, where @see Google\** is replaced with @see \Google\**. The extra \ causes the references to be matched correctly.

bshaffer
bshaffer approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for finding all these!

I prefer the relative references to the absolute ones, because they're more concise, but the most important thing by far is that they resolve correctly in our docs and code.

@bshaffer bshaffer added the next release PRs to be included in the next release label Sep 25, 2023
@vishwarajanand vishwarajanand marked this pull request as ready for review September 25, 2023 18:04
@vishwarajanand vishwarajanand requested review from a team as code owners September 25, 2023 18:04
@vishwarajanand vishwarajanand merged commit 6c746c6 into googleapis:main Sep 25, 2023
26 checks passed
@yash30201 yash30201 mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
next release PRs to be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vishwarajanand @bshaffer