Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Core: Remove error log entry on clean BiDi shutdown. #8806

Merged
merged 1 commit into from
Jul 29, 2019
Merged

API Core: Remove error log entry on clean BiDi shutdown. #8806

merged 1 commit into from
Jul 29, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 29, 2019

Closes #8803.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Jul 29, 2019
@tseaver tseaver requested a review from busunkim96 as a code owner July 29, 2019 19:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2019
@tseaver tseaver changed the title Pub/Sub: Remove error log entry on clean BiDi shutdown. API Core: Remove error log entry on clean BiDi shutdown. Jul 29, 2019
@tseaver tseaver requested a review from crwilcox July 29, 2019 19:34
plamut
plamut approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "error" is logged when an exception does not occur. Seems like a bogus error record, indeed.

@tseaver
Copy link
Contributor Author

tseaver commented Jul 29, 2019

Docs build failure on CircleCI addressed by #8805.

@tseaver tseaver merged commit ce5a8df into googleapis:master Jul 29, 2019
@tseaver tseaver deleted the 8803-pubsub-suppress-faux-error-log-bidi-exit branch July 29, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: core api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pub/Sub: logs littered with "The bidirectional RPC exited".
3 participants
@tseaver @plamut @googlebot