Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add isShutdown in HttpTransport #1901

Merged
merged 8 commits into from
Nov 27, 2023
Merged

feat: add isShutdown in HttpTransport #1901

merged 8 commits into from
Nov 27, 2023

Conversation

JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Nov 22, 2023 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1850 ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 22, 2023
@JoeWang1127 JoeWang1127 marked this pull request as ready for review November 22, 2023 15:05
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner November 22, 2023 15:05
blakeli0
blakeli0 reviewed Nov 22, 2023
View reviewed changes
google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java Show resolved Hide resolved
...pengine/src/main/java/com/google/api/client/extensions/appengine/http/UrlFetchTransport.java Outdated Show resolved Hide resolved
google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java Outdated
/**
* Default implementation of whether the http transport is shutdown or not.
*
* @since 1.4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version should be latest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, changed to 1.44.0 (the next release).

google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java Outdated Show resolved Hide resolved
@JoeWang1127 JoeWang1127 merged commit be00ce1 into main Nov 27, 2023
18 checks passed
@JoeWang1127 JoeWang1127 deleted the feat/implement-shutdown-for-httptransport branch November 27, 2023 16:29
@release-please release-please bot mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@lqiu96 lqiu96 Awaiting requested review from lqiu96

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate and Implement shutdown() and isShutdown() for NetHttpTransport
2 participants
@JoeWang1127 @blakeli0