Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: testing exlcusing commons-logging #1905

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Dec 5, 2023

List of classes that use commons-logging in org:apache:httpcomponents:httpclient:

Screenshot 2024-01-23 at 11 51 25 AM

List of classes that use org:apache:httpcomponents:httpclient in google-http-java-client:
Screenshot 2024-01-23 at 11 52 50 AM

Fortunately there's no overlap. Indeed the tests pass.

@suztomo suztomo merged commit 8e3f4d5 into googleapis:main Jan 23, 2024
18 checks passed
@suztomo suztomo deleted the is_commons_logging_needed branch January 23, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants