Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NIO to set file permissions #557

Merged
merged 5 commits into from Jun 17, 2019
Merged

Use NIO to set file permissions #557

merged 5 commits into from Jun 17, 2019

Conversation

chingor13
Copy link
Collaborator

Fixes #315

We're dropping Java 6 support in this next release, so we can now use NIO to set file permissions in Windows environments

@chingor13 chingor13 requested a review from a team as a code owner January 3, 2019 00:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 3, 2019
@chingor13
Copy link
Collaborator Author

Adding windows test runner in #562

@chingor13 chingor13 added the status: blocked Resolving the issue is dependent on other work. label Jan 4, 2019
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Feb 7, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@acurvers
Copy link

acurvers commented Jun 1, 2019

why did this not get merged?

@chingor13
Copy link
Collaborator Author

This was not merged as we were waiting until we set up a Windows test machine. This is blocked by #716

@chingor13 chingor13 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed status: blocked Resolving the issue is dependent on other work. labels Jun 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 16, 2019
@chingor13 chingor13 merged commit 4e77793 into googleapis:master Jun 17, 2019
@chingor13 chingor13 deleted the file-permissions-nio branch June 17, 2019 17:27
@kolea2 kolea2 mentioned this pull request Jul 31, 2019
Merged
@alapshin alapshin mentioned this pull request Sep 20, 2019
Closed
@diesieben07 diesieben07 mentioned this pull request Dec 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FileDataStoreFactory method setPermissionsToOwnerOnly only supports Unix
6 participants
@chingor13 @acurvers @sduskis @googlebot @kokoro-team @yoshi-automation