Fix ApacheHttpTransport configuration #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@chanseokoh We will backport this into a 1.30.2 release if it fixes the issue. |
chanseokoh
reviewed
Jun 14, 2019
| new PoolingHttpClientConnectionManager(-1, TimeUnit.MILLISECONDS); | ||
| // Disable the stale connection check (previously configured in the HttpConnectionParams | ||
| connectionManager.setValidateAfterInactivity(-1); | ||
|
|
||
| return HttpClientBuilder.create() | ||
| .useSystemProperties() | ||
| .setSSLSocketFactory(SSLConnectionSocketFactory.getSocketFactory()) |
There was a problem hiding this comment.
Would you remove this? By default, it will create and use SSLConnectionSocketFactory.getSocketFactory(). If this is set, I can't set .setSSLContext() or .setSSLHostnameVerifier() as they are overridden in the same manner with setConnectionManager().
There was a problem hiding this comment.
Hmm... that may not exactly be same when useSystemProperties() is set.
Nonetheless, I think I'm OK either way, since I can explicitly unset the factory by .setSSLSocketFactory(null), so not a big deal.
|
@chingor13 thanks! I'm OK if you make a new release or do a backport. This works in my testing. |
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
sduskis
approved these changes
Jun 18, 2019
chingor13
added a commit
that referenced
this pull request
Jun 21, 2019
* Switch back to deprecated setStaleConnectionCheck * checkstyle fix for TODO
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
…on URL for Workload Identity Federation (googleapis#717) * fix: add validation for the token URL and service account impersonation URL in ExternalAccountCredentials * fix: review comment * fix: add test case
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/google-auth-library-java/compare/v1.0.0...v1.1.0) (2021-08-17) ### Features * downscoping with credential access boundaries ([googleapis#702](https://www.github.com/googleapis/google-auth-library-java/issues/702)) ([aa7ede1](https://www.github.com/googleapis/google-auth-library-java/commit/aa7ede1d1c688ba437798f4204820c0506d5d969)) ### Bug Fixes * add validation for the token URL and service account impersonation URL for Workload Identity Federation ([googleapis#717](https://www.github.com/googleapis/google-auth-library-java/issues/717)) ([23cb8ef](https://www.github.com/googleapis/google-auth-library-java/commit/23cb8ef778d012bbd452c1dfdac5f096d1af6c95)) ### Documentation * updates README for downscoping with CAB ([googleapis#716](https://www.github.com/googleapis/google-auth-library-java/issues/716)) ([68bceba](https://www.github.com/googleapis/google-auth-library-java/commit/68bceba21c05870f6eb616cc057ddf0521c581b8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #715
Switch back to deprecated
setStaleConnectionCheck.HttpClientBuilderdoes not expose a way to configure the connection manager'svalidateAfterInactivityconfiguration. We can either reimplement the entirety of the builder's logic or switch back to a deprecated method.