Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkage Monitor #719

Merged
merged 4 commits into from Jun 14, 2019
Merged

Linkage Monitor #719

merged 4 commits into from Jun 14, 2019

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jun 14, 2019

@chingor13

Linkage Monitor notifies new linkage errors as presubmit check.

Fixes #718

  • Tests pass
  • Appropriate docs were updated (if necessary)

The presubmit job will not run until Kokoro job config is created (cl/253256348).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
@suztomo suztomo marked this pull request as ready for review June 14, 2019 17:48
@suztomo suztomo requested a review from a team as a code owner June 14, 2019 17:48
@chingor13 chingor13 self-assigned this Jun 14, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
curl -v -O "https://storage.googleapis.com/cloud-opensource-java-linkage-monitor/${JAR}"

# Fails if there's new linkage errors compared with baseline
java -jar $JAR com.google.cloud:libraries-bom
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the libraries-bom artifact needs a version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. The error message is expected (sorry the tool is not complete yet). Good for now. Let's keep this PR open.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works!

@chingor13 chingor13 added status: blocked Resolving the issue is dependent on other work. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
@chingor13 chingor13 removed the status: blocked Resolving the issue is dependent on other work. label Jun 14, 2019
@chingor13 chingor13 merged commit 3c91a65 into googleapis:master Jun 14, 2019
@suztomo suztomo deleted the linkage-monitor branch June 14, 2019 20:03
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* chore: remove java 7 units check

Source-Author: Neenu Shaji <Neenu1995@users.noreply.github.com>
Source-Date: Wed Jul 28 18:18:26 2021 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 1a2878d6909dd10ca4e3c1b5943d6622e996054e
Source-Link: googleapis/synthtool@1a2878d

* build(java): use ENABLE_FLAKYBOT env variable

Kokoro job config now supports both environment variables during this migration period.

Source-Author: Jeff Ching <chingor@google.com>
Source-Date: Thu Aug 12 10:10:27 2021 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ff01716e16d2c6e87eaf87197b753ac9fcbbed5d
Source-Link: googleapis/synthtool@ff01716

Co-authored-by: Emily Ball <emilyball@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kokoro build config Linkage Monitor
4 participants