Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: servlet classes that use the jakarta namespace #1115

Merged
merged 3 commits into from May 10, 2024
Merged

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented May 9, 2024

Fixes #1112, to support the jakarta.servlet namespace.

  • In addition to the namespace upgrade, the author, @since, and copyright year are updated.
  • The jakarta.servlet-api version 5 is declared as provided dependency. It's 5 (not the latest 6) because this repository is built with Java 8 and version 6 requires Java 11. It's "provided" scope because the servlet API artifacts in general are provided by the runtime (such as AppEngine).
  • The corresponding existing classes don't have tests. So I didn't add tests.
  • I ran my sample app using these classes and it worked. (work log)

@suztomo suztomo requested review from a team as code owners May 9, 2024 20:08
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 9, 2024
@suztomo suztomo marked this pull request as draft May 9, 2024 20:08
@suztomo suztomo requested review from meltsufin and westarle May 9, 2024 20:46
@suztomo suztomo marked this pull request as ready for review May 9, 2024 20:46
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update any public documentation?

@meltsufin
Copy link
Member

@ludoch PTAL

* }
* </pre>
*
* @since 1.36.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.36.0 is it the real new version that will be pushed? Otherwise, change it (and other files)

Copy link

@ludoch ludoch May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also curious if you need to configure Kokoro cfg files to enable SBOM generation (here and in all Cloud APIs area?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest is 1.35.0. This 1.36.0 is the real value to be released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking SBOM generation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed Kokoro configs are set up (log). Search for sbom.spdx.json.

@suztomo
Copy link
Member Author

suztomo commented May 9, 2024

Do we need to update any public documentation?

Yes, I'll update the document (https://developers.google.com/api-client-library/java/google-api-java-client/oauth2#web_server_applications).

@suztomo suztomo merged commit 11d6a3c into main May 10, 2024
17 checks passed
@suztomo suztomo deleted the jakarta_namespace branch May 10, 2024 17:26
suztomo added a commit to googleapis/google-api-java-client that referenced this pull request May 24, 2024
Fixes #2260

Copied the implementation with the jakarta.servlet namespace
using the same methology as googleapis/google-oauth-java-client#1115.

- Replaced javax with jakarta and declared the dependency with
  provided scope.
- Keeping the classes as `Beta` annotated.
- No tests exist for the classes.
- Added `@since 2.6.0` as the last release was 2.5.1.
suztomo added a commit to googleapis/google-api-java-client that referenced this pull request May 24, 2024
* feat: WebHookUtil classes using the jakarta namespace

Fixes #2260

Copied the implementation with the jakarta.servlet namespace
using the same methology as googleapis/google-oauth-java-client#1115.

- Replaced javax with jakarta and declared the dependency with
  provided scope.
- Keeping the classes as `Beta` annotated.
- No tests exist for the classes.
- Added `@since 2.6.0` as the last release was 2.5.1.

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for jakarta.servlet (EE10) in addition to the old javax.servlet (2.5 and 3.x) namespace
4 participants