New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation for JWT Profile for OAuth 2.0 Client Authentication an… #581
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/JWTAuthentication.java
Show resolved
Hide resolved
google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/JWTAuthentication.java
Show resolved
Hide resolved
import com.google.api.client.http.GenericUrl; | ||
import com.google.api.client.http.HttpRequest; | ||
import com.google.api.client.http.UrlEncodedContent; | ||
import com.google.api.client.json.jackson2.JacksonFactory; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import com.google.api.client.http.GenericUrl; | |
import com.google.api.client.http.HttpRequest; | |
import com.google.api.client.http.UrlEncodedContent; | |
import com.google.api.client.json.jackson2.JacksonFactory; | |
import static org.junit.Assert.assertThrows; | |
import java.util.Map; |
new ClientCredentialsTokenRequest(new MockHttpTransport(), new JacksonFactory(), | ||
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString())); | ||
|
||
JWTAuthentication auth = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new ClientCredentialsTokenRequest(new MockHttpTransport(), new JacksonFactory(), | |
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString())); | |
JWTAuthentication auth = | |
new ClientCredentialsTokenRequest( | |
new MockHttpTransport(), | |
new JacksonFactory(), | |
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString())); | |
JWTAuthentication auth = new JWTAuthentication(JWT); |
JWTAuthentication auth = | ||
new JWTAuthentication(JWT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JWTAuthentication auth = | |
new JWTAuthentication(JWT); | |
JWTAuthentication auth = new JWTAuthentication(JWT); |
new ClientCredentialsTokenRequest(new MockHttpTransport(), new JacksonFactory(), | ||
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString())); | ||
|
||
JWTAuthentication auth = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new ClientCredentialsTokenRequest(new MockHttpTransport(), new JacksonFactory(), | |
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString())); | |
JWTAuthentication auth = | |
new ClientCredentialsTokenRequest( | |
new MockHttpTransport(), | |
new JacksonFactory(), | |
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString())); | |
JWTAuthentication auth = new JWTAuthentication(JWT); |
google-oauth-client/src/test/java/com/google/api/client/auth/oauth2/JWTAuthenticationTest.java
Show resolved
Hide resolved
@googlebot I fixed it. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Will redo after sorting out CLA issues. |
…d Authorization.
Implementation modelled on ClientParametersAuthentication.
Fixes #580