Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for JWT Profile for OAuth 2.0 Client Authentication an… #581

Closed
wants to merge 3 commits into from

Conversation

junying1
Copy link

…d Authorization.

Implementation modelled on ClientParametersAuthentication.

Fixes #580

@junying1 junying1 requested a review from a team as a code owner December 29, 2020 00:19
@google-cla
Copy link

google-cla bot commented Dec 29, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 29, 2020
Comment on lines +17 to +20
import com.google.api.client.http.GenericUrl;
import com.google.api.client.http.HttpRequest;
import com.google.api.client.http.UrlEncodedContent;
import com.google.api.client.json.jackson2.JacksonFactory;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import com.google.api.client.http.GenericUrl;
import com.google.api.client.http.HttpRequest;
import com.google.api.client.http.UrlEncodedContent;
import com.google.api.client.json.jackson2.JacksonFactory;
import static org.junit.Assert.assertThrows;
import java.util.Map;

Comment on lines +41 to +44
new ClientCredentialsTokenRequest(new MockHttpTransport(), new JacksonFactory(),
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString()));

JWTAuthentication auth =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
new ClientCredentialsTokenRequest(new MockHttpTransport(), new JacksonFactory(),
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString()));
JWTAuthentication auth =
new ClientCredentialsTokenRequest(
new MockHttpTransport(),
new JacksonFactory(),
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString()));
JWTAuthentication auth = new JWTAuthentication(JWT);

Comment on lines +67 to +68
JWTAuthentication auth =
new JWTAuthentication(JWT);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
JWTAuthentication auth =
new JWTAuthentication(JWT);
JWTAuthentication auth = new JWTAuthentication(JWT);

Comment on lines +80 to +83
new ClientCredentialsTokenRequest(new MockHttpTransport(), new JacksonFactory(),
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString()));

JWTAuthentication auth =

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
new ClientCredentialsTokenRequest(new MockHttpTransport(), new JacksonFactory(),
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString()));
JWTAuthentication auth =
new ClientCredentialsTokenRequest(
new MockHttpTransport(),
new JacksonFactory(),
new GenericUrl(HttpTesting.SIMPLE_GENERIC_URL.toString()));
JWTAuthentication auth = new JWTAuthentication(JWT);

@junying1
Copy link
Author

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Dec 29, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@junying1
Copy link
Author

Will redo after sorting out CLA issues.

@junying1 junying1 closed this Dec 29, 2020
@junying1 junying1 deleted the jwt-authentication branch December 29, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWT Profile for OAuth 2.0 Client Authentication and Authorization Grants
2 participants