Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added throws clause Fixes #598 #743

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Conversation

schrosolver
Copy link
Contributor

@schrosolver schrosolver commented Sep 3, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #598 ☕️

@schrosolver schrosolver requested a review from a team as a code owner September 3, 2021 07:36
@google-cla

This comment has been minimized.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 3, 2021
@google-cla

This comment has been minimized.

@schrosolver
Copy link
Contributor Author

@googlebot I fixed it.

@google-cla

This comment has been minimized.

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 3, 2021
@schrosolver schrosolver changed the title Added throws clause Fixes #598 cleanup: Added throws clause Fixes #598 Sep 3, 2021
@chanseokoh chanseokoh added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2021
@chanseokoh chanseokoh changed the title cleanup: Added throws clause Fixes #598 chore: Added throws clause Fixes #598 Oct 8, 2021
@chanseokoh chanseokoh closed this Oct 8, 2021
@chanseokoh chanseokoh reopened this Oct 8, 2021
@schrosolver
Copy link
Contributor Author

schrosolver commented Oct 8, 2021

@chanseokoh can you please rerun the checks, I did formatting and pushed the code after rebasing.

@chanseokoh
Copy link
Contributor

@schrosolver looks like there's an inherent issue with the build infrastructure. Not sure why it's manifesting here.

@lesv
Copy link
Contributor

lesv commented Nov 3, 2021

ci / lint

Error:  Failed to execute goal com.coveo:fmt-maven-plugin:2.12:check (default-cli) on project google-oauth-client: Execution default-cli of goal com.coveo:fmt-maven-plugin:2.12:check failed: An API incompatibility was encountered while executing com.coveo:fmt-maven-plugin:2.12:check: java.lang.NoSuchMethodError: null
Error:  -----------------------------------------------------
Error:  realm =    plugin>com.coveo:fmt-maven-plugin:2.12
Error:  strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
Error:  urls[0] = file:/home/runner/.m2/repository/com/coveo/fmt-maven-plugin/2.12/fmt-maven-plugin-2.12.jar
Error:  urls[1] = file:/home/runner/.m2/repository/com/google/googlejavaformat/google-java-format/1.7/google-java-format-1.7.jar
Error:  urls[2] = file:/home/runner/.m2/repository/com/google/guava/guava/27.0.1-jre/guava-27.0.1-jre.jar
Error:  urls[3] = file:/home/runner/.m2/repository/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar
Error:  urls[4] = file:/home/runner/.m2/repository/com/google/guava/listenablefuture/9999.0-empty-to-avoid-conflict-with-guava/listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar
Error:  urls[5] = file:/home/runner/.m2/repository/com/google/code/findbugs/jsr305/3.0.2/jsr305-3.0.2.jar
Error:  urls[6] = file:/home/runner/.m2/repository/org/checkerframework/checker-qual/2.5.2/checker-qual-2.5.2.jar
Error:  urls[7] = file:/home/runner/.m2/repository/com/google/errorprone/error_prone_annotations/2.2.0/error_prone_annotations-2.2.0.jar
Error:  urls[8] = file:/home/runner/.m2/repository/com/google/j2objc/j2objc-annotations/1.1/j2objc-annotations-1.1.jar
Error:  urls[9] = file:/home/runner/.m2/repository/org/codehaus/mojo/animal-sniffer-annotations/1.17/animal-sniffer-annotations-1.17.jar
Error:  urls[10] = file:/home/runner/.m2/repository/com/google/errorprone/javac-shaded/9+181-r4173-1/javac-shaded-9+181-r4173-1.jar
Error:  urls[11] = file:/home/runner/.m2/repository/org/apache/commons/commons-lang3/3.8.1/commons-lang3-3.8.1.jar
Error:  urls[12] = file:/home/runner/.m2/repository/javax/enterprise/cdi-api/1.0/cdi-api-1.0.jar
Error:  urls[13] = file:/home/runner/.m2/repository/javax/annotation/jsr250-api/1.0/jsr250-api-1.0.jar
Error:  urls[14] = file:/home/runner/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.4/org.eclipse.sisu.inject-0.3.4.jar
Error:  urls[15] = file:/home/runner/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
Error:  urls[16] = file:/home/runner/.m2/repository/org/codehaus/plexus/plexus-utils/3.2.1/plexus-utils-3.2.1.jar
Error:  Number of foreign imports: 1
Error:  import: Entry[import  from realm ClassRealm[project>com.google.oauth-client:google-oauth-client-parent:1.32.2-SNAPSHOT, parent: ClassRealm[maven.api, parent: null]]]
Error:  
Error:  -----------------------------------------------------
Error:  : com.google.googlejavaformat.java.ImportOrderer.reorderImports(Ljava/lang/String;Lcom/google/googlejavaformat/java/JavaFormatterOptions$Style;)Ljava/lang/String;

@TimurSadykov
Copy link
Member

@lesv @chanseokoh this fixes the build: #768

@schrosolver
Copy link
Contributor Author

@chanseokoh can you please rerun the checks, after the PR #768 is merged, did a rebase again on this.

@chanseokoh chanseokoh merged commit 3c000c6 into googleapis:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing throws clauses
4 participants