-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Added throws clause Fixes #598 #743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
google-cla
bot
added
the
cla: no
This human has *not* signed the Contributor License Agreement.
label
Sep 3, 2021
This comment has been minimized.
This comment has been minimized.
@googlebot I fixed it. |
This comment has been minimized.
This comment has been minimized.
google-cla
bot
added
cla: yes
This human has signed the Contributor License Agreement.
and removed
cla: no
This human has *not* signed the Contributor License Agreement.
labels
Sep 3, 2021
Closed
schrosolver
changed the title
Added throws clause Fixes #598
cleanup: Added throws clause Fixes #598
Sep 3, 2021
chanseokoh
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Oct 8, 2021
chanseokoh
changed the title
cleanup: Added throws clause Fixes #598
chore: Added throws clause Fixes #598
Oct 8, 2021
@chanseokoh can you please rerun the checks, I did formatting and pushed the code after rebasing. |
@schrosolver looks like there's an inherent issue with the build infrastructure. Not sure why it's manifesting here. |
ci / lint
|
@lesv @chanseokoh this fixes the build: #768 |
@chanseokoh can you please rerun the checks, after the PR #768 is merged, did a rebase again on this. |
chanseokoh
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla: yes
This human has signed the Contributor License Agreement.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #598 ☕️