Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency com.google.guava:guava to v31 #755

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Sep 24, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.guava:guava 30.1-android -> 31.0-android age adoption passing confidence

Configuration

πŸ“… Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner September 24, 2021 21:12
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 24, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 24, 2021
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2021
@lesv lesv added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 24, 2021
@suztomo
Copy link
Member

suztomo commented Sep 27, 2021

RenovateBot, would you wait merging this until Guava team confirms their version next week?


Regarding the failure on Java 7:

Changed guava-android to generate Java 8 bytecode. We still restrict ourselves to using APIs available on Ice Cream Sandwich. So, as long as you have enabled Java 8 language features for your Android build, this change should have no effect on Android projects. This change does drop support for Java 7 JREs, as announced last year.

https://github.com/google/guava/releases/tag/v31.0

@suztomo suztomo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 27, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 27, 2021
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Sep 29, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 29, 2021
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Oct 1, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 1, 2021
@chanseokoh chanseokoh added the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2021
@suztomo suztomo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 8, 2021
@suztomo
Copy link
Member

suztomo commented Oct 8, 2021

Guava 31 is ok now.

@eaball35 eaball35 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2021
@renovate-bot renovate-bot force-pushed the renovate/major-project.guava.version branch from c889761 to f243b5a Compare October 26, 2021 17:24
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2021
@renovate-bot renovate-bot force-pushed the renovate/major-project.guava.version branch from f243b5a to 23ade51 Compare October 26, 2021 17:36
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 26, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2021
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2021
@lesv lesv removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2021
@lesv
Copy link
Contributor

lesv commented Nov 3, 2021

CI / Units

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.google.api.client.auth.openidconnect.IdTokenTest
Error:  Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.051 s <<< FAILURE! - in com.google.api.client.auth.openidconnect.IdTokenTest
Error:  com.google.api.client.auth.openidconnect.IdTokenTest.testValidateIssuer  Time elapsed: 0.003 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions : Unsupported major.minor version 52.0
	at com.google.api.client.auth.openidconnect.IdTokenTest.testValidateIssuer(IdTokenTest.java:28)

Error:  com.google.api.client.auth.openidconnect.IdTokenTest.testValidateIssuedAtTime  Time elapsed: 0.001 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenTest.testValidateIssuedAtTime(IdTokenTest.java:36)

Error:  com.google.api.client.auth.openidconnect.IdTokenTest.testValidateAudience  Time elapsed: 0.001 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenTest.testValidateAudience(IdTokenTest.java:54)

Error:  com.google.api.client.auth.openidconnect.IdTokenTest.testValidateNoAudienceSet  Time elapsed: 0.001 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenTest.testValidateNoAudienceSet(IdTokenTest.java:70)

Error:  com.google.api.client.auth.openidconnect.IdTokenTest.testConstructor  Time elapsed: 0 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenTest.testConstructor(IdTokenTest.java:89)

Error:  com.google.api.client.auth.openidconnect.IdTokenTest.testValidateExpirationTime  Time elapsed: 0.001 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenTest.testValidateExpirationTime(IdTokenTest.java:45)

Error:  com.google.api.client.auth.openidconnect.IdTokenTest.testValidateTime  Time elapsed: 0.001 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenTest.testValidateTime(IdTokenTest.java:76)

[INFO] Running com.google.api.client.auth.openidconnect.IdTokenVerifierTest
Error:  Tests run: 5, Failures: 0, Errors: 5, Skipped: 0, Time elapsed: 0 s <<< FAILURE! - in com.google.api.client.auth.openidconnect.IdTokenVerifierTest
Error:  com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testBuilderSetNullIssuers  Time elapsed: 0 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testBuilderSetNullIssuers(IdTokenVerifierTest.java:126)

Error:  com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testEmptyIssuersFails  Time elapsed: 0 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testEmptyIssuersFails(IdTokenVerifierTest.java:111)

Error:  com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testBuilder  Time elapsed: 0 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testBuilder(IdTokenVerifierTest.java:52)

Error:  com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testMissingAudience  Time elapsed: 0 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.openidconnect.IdTokenVerifierTest.newIdToken(IdTokenVerifierTest.java:43)
	at com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testMissingAudience(IdTokenVerifierTest.java:142)

Error:  com.google.api.client.auth.openidconnect.IdTokenVerifierTest.testVerify  Time elapsed: 0 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
[INFO] Running com.google.api.client.auth.oauth2.CustomTokenRequestTest
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.001 s <<< FAILURE! - in com.google.api.client.auth.oauth2.CustomTokenRequestTest
Error:  com.google.api.client.auth.oauth2.CustomTokenRequestTest.initializationError  Time elapsed: 0 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.oauth2.CustomTokenRequestTest.<clinit>(CustomTokenRequestTest.java:39)

[INFO] Running com.google.api.client.auth.oauth2.TokenResponseTest
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.001 s <<< FAILURE! - in com.google.api.client.auth.oauth2.TokenResponseTest
Error:  com.google.api.client.auth.oauth2.TokenResponseTest.test  Time elapsed: 0 s  <<< ERROR!
java.lang.UnsupportedClassVersionError: com/google/common/base/Preconditions
	at com.google.api.client.auth.oauth2.TokenResponseTest.test(TokenResponseTest.java:36)

[INFO] Running com.google.api.client.auth.oauth2.AuthorizationCodeFlowTest
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.001 s <<< FAILURE! - in com.google.api.client.auth.oauth2.AuthorizationCodeFlowTest
Error:  com.google.api.client.auth.oauth2.AuthorizationCodeFlowTest.initializationError  Time elapsed: 0 s  <<< ERROR!
java.lang.NoClassDefFoundError: com.google.api.client.auth.oauth2.AuthenticationTestBase

[INFO] 
[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    OAuthHmacSha256SignerTest.testComputeSignature:52 Β» UnsupportedClassVersion co...
Error:    OAuthHmacSha256SignerTest.testComputeSignatureWithNullClientSecret:37 Β» UnsupportedClassVersion
Error:    OAuthHmacSha256SignerTest.testComputeSignatureWithNullSecrets:29 Β» UnsupportedClassVersion
Error:    OAuthHmacSha256SignerTest.testComputeSignatureWithNullTokenSecret:44 Β» UnsupportedClassVersion
Error:    OAuthHmacSignerTest.testComputeSignature:33 Β» UnsupportedClassVersion com/goog...
Error:    OAuthParametersTest.testEscape:46 Β» UnsupportedClassVersion com/google/common/...
Error:    OAuthParametersTest.testGetAuthorizationHeader:56 Β» UnsupportedClassVersion co...
Error:    OAuthParametersTest.testSignature:74 Β» UnsupportedClassVersion com/google/comm...
Error:    OAuthParametersTest.testSignatureWithRepeatedParameter:104 Β» UnsupportedClassVersion
Error:    OAuthParametersTest.testSignatureWithUrlEncodedContent:85 Β» UnsupportedClassVersion
Error:    OAuthRsaSignerTest.testComputeSignature:41 Β» UnsupportedClassVersion com/googl...
Error:    AuthorizationCodeFlowTest.initializationError Β» NoClassDefFound com.google.api...
Error:    AuthorizationCodeRequestUrlTest.testBuild:37 Β» UnsupportedClassVersion com/goo...
Error:    AuthorizationCodeResponseUrlTest.testConstructor:28 Β» UnsupportedClassVersion ...
Error:    AuthorizationCodeTokenRequestTest.testConstructor:31 NoClassDefFound Could not...
Error:    AuthorizationCodeTokenRequestTest.testSetResponseClass:47 NoClassDefFound Coul...
Error:    AuthorizationRequestUrlTest.testBuild:37 Β» UnsupportedClassVersion com/google/...
Error:    BrowserClientRequestUrlTest.testBuild:33 Β» UnsupportedClassVersion com/google/...
Error:    ClientCredentialsTokenRequestTest.testConstructor:28 NoClassDefFound Could not...
Error:    ClientCredentialsTokenRequestTest.testSetResponseClass:40 NoClassDefFound Coul...
Error:    ClientParametersAuthenticationTest.test:35 NoClassDefFound Could not initializ...
Error:    ClientParametersAuthenticationTest.test_noSecret:52 Β» UnsupportedClassVersion ...
Error:    CredentialTest>AuthenticationTestBase.<clinit>:40 Β» UnsupportedClassVersion co...
Error:    CustomTokenRequestTest.<clinit>:39 Β» UnsupportedClassVersion com/google/common...
Error:    CustomTokenResponseTest.testStringExpires:52 Β» UnsupportedClassVersion com/goo...
Error:    PasswordTokenRequestTest.testConstructor:31 NoClassDefFound Could not initiali...
Error:    PasswordTokenRequestTest.testSetResponseClass:47 Β» UnsupportedClassVersion com...
Error:    RefreshTokenRequestTest.testConstructor:30 NoClassDefFound Could not initializ...
Error:    RefreshTokenRequestTest.testSetResponseClass:44 NoClassDefFound Could not init...
Error:    TokenErrorResponseTest.test:35 Β» UnsupportedClassVersion com/google/common/bas...
Error:    TokenRequestTest.initializationError Β» NoClassDefFound Could not initialize cl...
Error:    TokenResponseTest.test:36 Β» UnsupportedClassVersion com/google/common/base/Pre...
Error:    IdTokenTest.testConstructor:89 Β» UnsupportedClassVersion com/google/common/bas...
Error:    IdTokenTest.testValidateAudience:54 Β» UnsupportedClassVersion com/google/commo...
Error:    IdTokenTest.testValidateExpirationTime:45 Β» UnsupportedClassVersion com/google...
Error:    IdTokenTest.testValidateIssuedAtTime:36 Β» UnsupportedClassVersion com/google/c...
Error:    IdTokenTest.testValidateIssuer:28 Β» UnsupportedClassVersion com/google/common/...
Error:    IdTokenTest.testValidateNoAudienceSet:70 Β» UnsupportedClassVersion com/google/...
Error:    IdTokenTest.testValidateTime:76 Β» UnsupportedClassVersion com/google/common/ba...
Error:    IdTokenVerifierTest.testBuilder:52 Β» UnsupportedClassVersion com/google/common...
Error:    IdTokenVerifierTest.testBuilderSetNullIssuers:126 Β» UnsupportedClassVersion co...
Error:    IdTokenVerifierTest.testEmptyIssuersFails:111 Β» UnsupportedClassVersion com/go...
Error:    IdTokenVerifierTest.testMissingAudience:142->newIdToken:43 Β» UnsupportedClassVersion
Error:    IdTokenVerifierTest.testVerify:79 Β» UnsupportedClassVersion com/google/common/...
[INFO] 
Error:  Tests run: 44, Failures: 0, Errors: 44, Skipped: 0

@lesv
Copy link
Contributor

lesv commented Nov 3, 2021

@TimurSadykov Actually this is the one that Guava upgrades to 31 and unit tests fail.

@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Nov 3, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 4, 2021
@lesv lesv added the automerge Merge the pull request once unit tests and other checks pass. label Nov 5, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 5, 2021
@TimurSadykov
Copy link
Member

@lesv Guava drops java7 starting with v31. this PR updates Guava and removes java7 units: #768

@forking-renovate
Copy link

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 31.x releases. However, if you upgrade to 31.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate-bot renovate-bot deleted the renovate/major-project.guava.version branch November 7, 2021 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants