Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit version range needed for dependency pytest-asyncio? #219

Open
cojenco opened this issue May 11, 2021 · 1 comment
Open

Explicit version range needed for dependency pytest-asyncio? #219

cojenco opened this issue May 11, 2021 · 1 comment
Assignees
@cojenco
Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. type: process A process-related concern. May include testing, release, or the like.

Comments

@cojenco
Copy link
Contributor

cojenco commented May 11, 2021

System test failure was due to a pytest-asyncio package issue, in which the loop cleanup changes were causing test errors. To unblock PR submissions, a fix is submitted to pin pytest-asyncio to previous working version. Follow up with dependency change and whether or not we should keep it pinned with version range.
@cojenco cojenco self-assigned this May 11, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/google-resumable-media-python API. label May 11, 2021
@cojenco cojenco added the type: question Request for information or clarification. Not an issue. label May 11, 2021
@cojenco cojenco mentioned this issue Jul 20, 2021
Closed
@cojenco cojenco added type: process A process-related concern. May include testing, release, or the like. and removed type: question Request for information or clarification. Not an issue. labels Aug 25, 2021
@seifertm
Copy link

Hi, pytest-asyncio maintainer here.

Sorry that you experienced issues with pytest-asyncio v0.15. A lot has happened since then and pytest-asyncio is now at v0.18.2. I encourage you to try the latest version. Any feedback would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cojenco cojenco

Labels
api: storage Issues related to the googleapis/google-resumable-media-python API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: unpin dependency pytest-asyncio cojenco/google-resumable-media-python
2 participants
@seifertm @cojenco