tests: unpin dependency pytest-asyncio #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
google-cla
bot
added
the
cla: yes
tseaver
reviewed
Jul 21, 2021
| @@ -40,7 +40,7 @@ def unit(session): | |||
| ) | |||
|
|
|||
| # Install all test dependencies, then install this package in-place. | |||
| session.install("mock", "pytest", "pytest-cov", "pytest-asyncio<=0.14.0", GOOGLE_AUTH) | |||
| session.install("mock", "pytest", "pytest-cov", "pytest-asyncio", GOOGLE_AUTH) | |||
There was a problem hiding this comment.
Given that this is a test-only dependency, maybe we should be adding , "-c", constraints_path here, and then maybe excluding the known-bad versions in testing/constraints*.txt. Likewise for the system test session below.
|
The issue remains open, and not yet resolved in 0.15.0 nor 0.15.1, per pytest-asyncio issue#211 . Closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous issue seen in #218 pytest-asyncio 0.15.0 resolved in 0.15.1
Fixes #219