Skip to content

Commit

Permalink
fix!: mark parent/name fields with the REQUIRED field_behavior annota…
Browse files Browse the repository at this point in the history
…tion

docs: updated comments

PiperOrigin-RevId: 624277410
  • Loading branch information
Google APIs authored and Copybara-Service committed Apr 12, 2024
1 parent 72bfead commit 2d881be
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 12 deletions.
21 changes: 13 additions & 8 deletions google/cloud/bigquery/datatransfer/v1/datatransfer.proto
Expand Up @@ -867,12 +867,15 @@ message StartManualTransferRunsRequest {
google.protobuf.Timestamp end_time = 2;
}

// Transfer configuration name in the form:
// Required. Transfer configuration name in the form:
// `projects/{project_id}/transferConfigs/{config_id}` or
// `projects/{project_id}/locations/{location_id}/transferConfigs/{config_id}`.
string parent = 1 [(google.api.resource_reference) = {
type: "bigquerydatatransfer.googleapis.com/TransferConfig"
}];
string parent = 1 [
(google.api.field_behavior) = REQUIRED,
(google.api.resource_reference) = {
type: "bigquerydatatransfer.googleapis.com/TransferConfig"
}
];

// The requested time specification - this can be a time range or a specific
// run_time.
Expand Down Expand Up @@ -900,8 +903,9 @@ message StartManualTransferRunsResponse {
// A request to enroll a set of data sources so they are visible in the
// BigQuery UI's `Transfer` tab.
message EnrollDataSourcesRequest {
// The name of the project resource in the form: `projects/{project_id}`
string name = 1;
// Required. The name of the project resource in the form:
// `projects/{project_id}`
string name = 1 [(google.api.field_behavior) = REQUIRED];

// Data sources that are enrolled. It is required to provide at least one
// data source id.
Expand All @@ -911,8 +915,9 @@ message EnrollDataSourcesRequest {
// A request to unenroll a set of data sources so they are no longer visible in
// the BigQuery UI's `Transfer` tab.
message UnenrollDataSourcesRequest {
// The name of the project resource in the form: `projects/{project_id}`
string name = 1;
// Required. The name of the project resource in the form:
// `projects/{project_id}`
string name = 1 [(google.api.field_behavior) = REQUIRED];

// Data sources that are unenrolled. It is required to provide at least one
// data source id.
Expand Down
8 changes: 4 additions & 4 deletions google/cloud/bigquery/datatransfer/v1/transfer.proto
Expand Up @@ -117,14 +117,14 @@ message TransferConfig {
pattern: "projects/{project}/locations/{location}/transferConfigs/{transfer_config}"
};

// The resource name of the transfer config.
// Identifier. The resource name of the transfer config.
// Transfer config names have the form either
// `projects/{project_id}/locations/{region}/transferConfigs/{config_id}` or
// `projects/{project_id}/transferConfigs/{config_id}`,
// where `config_id` is usually a UUID, even though it is not
// guaranteed or required. The name is ignored when creating a transfer
// config.
string name = 1;
string name = 1 [(google.api.field_behavior) = IDENTIFIER];

// The desination of the transfer config.
oneof destination {
Expand Down Expand Up @@ -231,11 +231,11 @@ message TransferRun {
pattern: "projects/{project}/locations/{location}/transferConfigs/{transfer_config}/runs/{run}"
};

// The resource name of the transfer run.
// Identifier. The resource name of the transfer run.
// Transfer run names have the form
// `projects/{project_id}/locations/{location}/transferConfigs/{config_id}/runs/{run_id}`.
// The name is ignored when creating a transfer run.
string name = 1;
string name = 1 [(google.api.field_behavior) = IDENTIFIER];

// Minimum time after which a transfer run can be started.
google.protobuf.Timestamp schedule_time = 3;
Expand Down

0 comments on commit 2d881be

Please sign in to comment.