feat: clients for Notebooks API V2

docs: supports Workbench Instances https://cloud.google.com/vertex-ai/docs/workbench/reference/rest PiperOrigin-RevId: 558178233
googleapis · Aug 18, 2023 · ad329f8 · ad329f8
1 parent 2937457
commit ad329f8
Show file tree

Hide file tree

Showing 7 changed files with 77 additions and 23 deletions.
diff --git a/google/cloud/notebooks/logging/v1/BUILD.bazel b/google/cloud/notebooks/logging/v1/BUILD.bazel
@@ -23,19 +23,22 @@ proto_library(
 ##############################################################################
 load(
     "@com_google_googleapis_imports//:imports.bzl",
-    "java_grpc_library",
     "java_proto_library",
+    "java_gapic_assembly_gradle_pkg",
 )
 
 java_proto_library(
     name = "logging_java_proto",
     deps = [":logging_proto"],
 )
 
-java_grpc_library(
-    name = "logging_java_grpc",
-    srcs = [":logging_proto"],
-    deps = [":logging_java_proto"],
+# Open Source Packages
+java_gapic_assembly_gradle_pkg(
+    name = "google-cloud-notebooks-logging-v1-java",
+    deps = [
+        ":logging_proto",
+        ":logging_java_proto",
+    ],
 )
 
 ##############################################################################
@@ -58,7 +61,7 @@ go_proto_library(
 )
 
 go_gapic_assembly_pkg(
-    name = "logging-v1-go",
+    name = "google-cloud-notebooks-logging-v1-go",
     deps = [
         ":logging_go_proto",
     ],
@@ -108,7 +111,7 @@ php_proto_library(
 )
 
 php_gapic_assembly_pkg(
-    name = "logging-v1-php",
+    name = "google-cloud-notebooks-logging-v1-php",
     deps = [
         ":logging_php_proto",
     ],
@@ -139,7 +142,7 @@ ruby_grpc_library(
 ##############################################################################
 load(
     "@com_google_googleapis_imports//:imports.bzl",
-    "csharp_grpc_library",
+    "csharp_gapic_assembly_pkg",
     "csharp_proto_library",
 )
 
@@ -148,10 +151,14 @@ csharp_proto_library(
     deps = [":logging_proto"],
 )
 
-csharp_grpc_library(
-    name = "logging_csharp_grpc",
-    srcs = [":logging_proto"],
-    deps = [":logging_csharp_proto"],
+# Open Source Packages
+csharp_gapic_assembly_pkg(
+    name = "google-cloud-notebooks-logging-v1-csharp",
+    package_name = "Google.Cloud.Notebooks.Logging.V1",
+    generate_nongapic_package = True,
+    deps = [
+        ":logging_csharp_proto",
+    ],
 )
 
 ##############################################################################

diff --git a/google/cloud/notebooks/logging/v1/runtime_log.proto b/google/cloud/notebooks/logging/v1/runtime_log.proto
@@ -18,6 +18,7 @@ package google.cloud.notebooks.logging.v1;
 
 import "google/api/field_behavior.proto";
 
+option csharp_namespace = "Google.Cloud.Notebooks.Logging.V1";
 option go_package = "cloud.google.com/go/notebooks/logging/apiv1/loggingpb;loggingpb";
 option java_multiple_files = true;
 option java_outer_classname = "RuntimeLogProto";

diff --git a/google/cloud/notebooks/v1/BUILD.bazel b/google/cloud/notebooks/v1/BUILD.bazel
@@ -346,7 +346,6 @@ load(
 
 csharp_proto_library(
     name = "notebooks_csharp_proto",
-    extra_opts = [],
     deps = [":notebooks_proto"],
 )
 

diff --git a/google/cloud/notebooks/v1beta1/BUILD.bazel b/google/cloud/notebooks/v1beta1/BUILD.bazel
@@ -337,7 +337,6 @@ load(
 
 csharp_proto_library(
     name = "notebooks_csharp_proto",
-    extra_opts = [],
     deps = [":notebooks_proto"],
 )
 

diff --git a/google/cloud/notebooks/v2/BUILD.bazel b/google/cloud/notebooks/v2/BUILD.bazel
@@ -43,8 +43,8 @@ proto_library_with_info(
     name = "notebooks_proto_with_info",
     deps = [
         ":notebooks_proto",
-        "//google/cloud/location:location_proto",
         "//google/cloud:common_resources_proto",
+        "//google/cloud/location:location_proto",
         "//google/iam/v1:iam_policy_proto",
     ],
 )
@@ -105,14 +105,14 @@ java_gapic_test(
 # Open Source Packages
 java_gapic_assembly_gradle_pkg(
     name = "google-cloud-notebooks-v2-java",
+    include_samples = True,
     transport = "grpc+rest",
     deps = [
         ":notebooks_java_gapic",
         ":notebooks_java_grpc",
         ":notebooks_java_proto",
         ":notebooks_proto",
     ],
-    include_samples = True,
 )
 
 ##############################################################################
@@ -161,9 +161,9 @@ go_gapic_assembly_pkg(
     name = "gapi-cloud-notebooks-v2-go",
     deps = [
         ":notebooks_go_gapic",
-        ":notebooks_go_gapic_srcjar-test.srcjar",
         ":notebooks_go_gapic_srcjar-metadata.srcjar",
         ":notebooks_go_gapic_srcjar-snippets.srcjar",
+        ":notebooks_go_gapic_srcjar-test.srcjar",
         ":notebooks_go_proto",
     ],
 )
@@ -227,8 +227,8 @@ php_gapic_library(
     name = "notebooks_php_gapic",
     srcs = [":notebooks_proto_with_info"],
     grpc_service_config = "notebooks_grpc_service_config.json",
-    rest_numeric_enums = True,
     migration_mode = "NEW_SURFACE_ONLY",
+    rest_numeric_enums = True,
     service_yaml = "notebooks_v2.yaml",
     transport = "grpc+rest",
     deps = [
@@ -280,8 +280,8 @@ nodejs_gapic_assembly_pkg(
 ##############################################################################
 load(
     "@com_google_googleapis_imports//:imports.bzl",
-    "ruby_gapic_assembly_pkg",
     "ruby_cloud_gapic_library",
+    "ruby_gapic_assembly_pkg",
     "ruby_grpc_library",
     "ruby_proto_library",
 )
@@ -300,9 +300,7 @@ ruby_grpc_library(
 ruby_cloud_gapic_library(
     name = "notebooks_ruby_gapic",
     srcs = [":notebooks_proto_with_info"],
-    extra_protoc_parameters = [
-        "ruby-cloud-gem-name=google-cloud-notebooks-v2",
-    ],
+    extra_protoc_parameters = ["ruby-cloud-gem-name=google-cloud-notebooks-v2"],
     grpc_service_config = "notebooks_grpc_service_config.json",
     rest_numeric_enums = True,
     service_yaml = "notebooks_v2.yaml",
@@ -336,7 +334,6 @@ load(
 
 csharp_proto_library(
     name = "notebooks_csharp_proto",
-    extra_opts = [],
     deps = [":notebooks_proto"],
 )
 

diff --git a/google/cloud/notebooks/v2/notebooks_v2.yaml b/google/cloud/notebooks/v2/notebooks_v2.yaml
@@ -105,3 +105,47 @@ authentication:
     oauth:
       canonical_scopes: |-
         https://www.googleapis.com/auth/cloud-platform
+
+publishing:
+  new_issue_uri: https://issuetracker.google.com/issues/new?component=1392625
+  documentation_uri: https://cloud.google.com/vertex-ai/docs/workbench/instances/introduction
+  api_short_name: notebooks
+  github_label: 'api: notebooks'
+  doc_tag_prefix: notebooks
+  organization: CLOUD
+  library_settings:
+  - version: google.cloud.notebooks.v2
+    launch_stage: GA
+    java_settings:
+      common:
+        destinations:
+        - PACKAGE_MANAGER
+    cpp_settings:
+      common:
+        destinations:
+        - PACKAGE_MANAGER
+    php_settings:
+      common:
+        destinations:
+        - PACKAGE_MANAGER
+    python_settings:
+      common:
+        destinations:
+        - PACKAGE_MANAGER
+    node_settings:
+      common:
+        destinations:
+        - PACKAGE_MANAGER
+    dotnet_settings:
+      common:
+        destinations:
+        - PACKAGE_MANAGER
+    ruby_settings:
+      common:
+        destinations:
+        - PACKAGE_MANAGER
+    go_settings:
+      common:
+        destinations:
+        - PACKAGE_MANAGER
+  proto_reference_documentation_uri: https://cloud.google.com/vertex-ai/docs/workbench/reference/rest
diff --git a/google/cloud/notebooks/v2/service.proto b/google/cloud/notebooks/v2/service.proto
@@ -233,6 +233,13 @@ message ListInstancesRequest {
   // Optional. A previous returned page token that can be used to continue
   // listing from the last result.
   string page_token = 3 [(google.api.field_behavior) = OPTIONAL];
+
+  // Optional. Sort results. Supported values are "name", "name desc" or ""
+  // (unsorted).
+  string order_by = 4 [(google.api.field_behavior) = OPTIONAL];
+
+  // Optional. List filter.
+  string filter = 5 [(google.api.field_behavior) = OPTIONAL];
 }
 
 // Response for listing notebook instances.