Skip to content

Commit

Permalink
docs: Minor comment updates
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 617427819
  • Loading branch information
Google APIs authored and Copybara-Service committed Mar 20, 2024
1 parent d30cda1 commit ba8609a
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 15 deletions.
28 changes: 16 additions & 12 deletions google/cloud/asset/v1/asset_service.proto
Expand Up @@ -1392,10 +1392,10 @@ message IamPolicyAnalysisQuery {
// folder number (such as "folders/123"), a project ID (such as
// "projects/my-project-id"), or a project number (such as "projects/12345").
//
// To know how to get organization id, visit [here
// To know how to get organization ID, visit [here
// ](https://cloud.google.com/resource-manager/docs/creating-managing-organization#retrieving_your_organization_id).
//
// To know how to get folder or project id, visit [here
// To know how to get folder or project ID, visit [here
// ](https://cloud.google.com/resource-manager/docs/creating-managing-folders#viewing_or_listing_folders_and_projects).
string scope = 1 [(google.api.field_behavior) = REQUIRED];

Expand Down Expand Up @@ -2082,10 +2082,10 @@ message BatchGetEffectiveIamPoliciesRequest {
// folder number (such as "folders/123"), a project ID (such as
// "projects/my-project-id"), or a project number (such as "projects/12345").
//
// To know how to get organization id, visit [here
// To know how to get organization ID, visit [here
// ](https://cloud.google.com/resource-manager/docs/creating-managing-organization#retrieving_your_organization_id).
//
// To know how to get folder or project id, visit [here
// To know how to get folder or project ID, visit [here
// ](https://cloud.google.com/resource-manager/docs/creating-managing-folders#viewing_or_listing_folders_and_projects).
string scope = 1 [
(google.api.field_behavior) = REQUIRED,
Expand Down Expand Up @@ -2181,8 +2181,8 @@ message AnalyzerOrgPolicy {
}

oneof kind {
// List of values to be used for this PolicyRule. This field can be set
// only in Policies for list constraints.
// List of values to be used for this policy rule. This field can be set
// only in policies for list constraints.
StringValues values = 3;

// Setting this to true means that all values are allowed. This field can
Expand All @@ -2204,14 +2204,18 @@ message AnalyzerOrgPolicy {

// The condition evaluation result for this rule.
// Only populated if it meets all the following criteria:
// * there is a
//
// * There is a
// [condition][google.cloud.asset.v1.AnalyzerOrgPolicy.Rule.condition]
// defined for this rule
// * this rule is within a consolidated_policy
// * the consolidated_policy is within
// [AnalyzeOrgPolicyGovernedContainersResponse.GovernedContainer][google.cloud.asset.v1.AnalyzeOrgPolicyGovernedContainersResponse.GovernedContainer]
// defined for this rule.
// * This rule is within
// [AnalyzeOrgPolicyGovernedContainersResponse.GovernedContainer.consolidated_policy][google.cloud.asset.v1.AnalyzeOrgPolicyGovernedContainersResponse.GovernedContainer.consolidated_policy],
// or
// [AnalyzeOrgPolicyGovernedAssetsResponse.GovernedResource][google.cloud.asset.v1.AnalyzeOrgPolicyGovernedAssetsResponse.GovernedResource]
// [AnalyzeOrgPolicyGovernedAssetsResponse.GovernedAsset.consolidated_policy][google.cloud.asset.v1.AnalyzeOrgPolicyGovernedAssetsResponse.GovernedAsset.consolidated_policy]
// when the
// [AnalyzeOrgPolicyGovernedAssetsResponse.GovernedAsset][google.cloud.asset.v1.AnalyzeOrgPolicyGovernedAssetsResponse.GovernedAsset]
// has
// [AnalyzeOrgPolicyGovernedAssetsResponse.GovernedAsset.governed_resource][google.cloud.asset.v1.AnalyzeOrgPolicyGovernedAssetsResponse.GovernedAsset.governed_resource].
ConditionEvaluation condition_evaluation = 8;
}

Expand Down
6 changes: 3 additions & 3 deletions google/cloud/asset/v1/assets.proto
Expand Up @@ -304,7 +304,7 @@ message RelatedAsset {
}

// The key and value for a
// [tag](https://cloud.google.com/resource-manager/docs/tags/tags-overview),
// [tag](https://cloud.google.com/resource-manager/docs/tags/tags-overview).
message Tag {
// TagKey namespaced name, in the format of {ORG_ID}/{TAG_KEY_SHORT_NAME}.
optional string tag_key = 1;
Expand Down Expand Up @@ -858,7 +858,7 @@ message IamPolicyAnalysisState {
string cause = 2;
}

// The Condition evaluation.
// The condition evaluation.
message ConditionEvaluation {
// Value of this expression.
enum EvaluationValue {
Expand All @@ -873,7 +873,7 @@ message ConditionEvaluation {

// The evaluation result is `conditional` when the condition expression
// contains variables that are either missing input values or have not been
// supported by Analyzer yet.
// supported by Policy Analyzer yet.
CONDITIONAL = 3;
}

Expand Down

0 comments on commit ba8609a

Please sign in to comment.