Skip to content

Commit

Permalink
feat: Add comment to the unsupported order_by field of ListTasksRequest
Browse files Browse the repository at this point in the history
---
feat: Enable gpu driver version field on v1

---
feat: allow order_by for v1 ListJobs

---
feat: Improve url examples formats on Batch API comments
PiperOrigin-RevId: 552573521
  • Loading branch information
Google APIs authored and Copybara-Service committed Jul 31, 2023
1 parent 992c4f4 commit c34b78b
Show file tree
Hide file tree
Showing 2 changed files with 48 additions and 16 deletions.
4 changes: 4 additions & 0 deletions google/cloud/batch/v1/batch.proto
Expand Up @@ -177,6 +177,10 @@ message ListJobsRequest {
// List filter.
string filter = 4;

// Optional. Sort results. Supported are "name", "name desc", "create_time",
// and "create_time desc".
string order_by = 5 [(google.api.field_behavior) = OPTIONAL];

// Page size.
int32 page_size = 2;

Expand Down
60 changes: 44 additions & 16 deletions google/cloud/batch/v1/job.proto
Expand Up @@ -249,21 +249,24 @@ message AllocationPolicy {
message Disk {
// A data source from which a PD will be created.
oneof data_source {
// Name of a public or custom image used as the data source.
// Name of an image used as the data source.
// For example, the following are all valid URLs:
//
// * Specify the image by its family name:
// projects/{project}/global/images/family/{image_family}
// <pre><code>projects/<var
// class="apiparam">project</var>/global/images/family/<var
// class="apiparam">image_family</var></code></pre>
// * Specify the image version:
// projects/{project}/global/images/{image_version}
//
// <pre>projects/<var
// class="apiparam">project</var>/global/images/<var
// class="apiparam">image_version</var></code></pre>
// You can also use Batch customized image in short names.
// The following image values are supported for a boot disk:
//
// * "batch-debian": use Batch Debian images.
// * "batch-centos": use Batch CentOS images.
// * "batch-cos": use Batch Container-Optimized images.
// * "batch-hpc-centos": use Batch HPC CentOS images.
// * `batch-debian`: use Batch Debian images.
// * `batch-centos`: use Batch CentOS images.
// * `batch-cos`: use Batch Container-Optimized images.
// * `batch-hpc-centos`: use Batch HPC CentOS images.
string image = 4;

// Name of a snapshot used as the data source.
Expand Down Expand Up @@ -323,6 +326,15 @@ message AllocationPolicy {

// Deprecated: please use instances[0].install_gpu_drivers instead.
bool install_gpu_drivers = 3 [deprecated = true];

// Optional. The NVIDIA GPU driver version that should be installed for this
// type.
//
// You can define the specific driver version such as "470.103.01",
// following the driver version requirements in
// https://cloud.google.com/compute/docs/gpus/install-drivers-gpu#minimum-driver.
// Batch will install the specific accelerator driver if qualified.
string driver_version = 4 [(google.api.field_behavior) = OPTIONAL];
}

// InstancePolicy describes an instance type and resources attached to each VM
Expand Down Expand Up @@ -368,6 +380,12 @@ message AllocationPolicy {
// third party location and install them for GPUs specified in
// policy.accelerators or instance_template on their behalf. Default is
// false.
//
// For Container-Optimized Image cases, Batch will install the
// accelerator driver following milestones of
// https://cloud.google.com/container-optimized-os/docs/release-notes. For
// non Container-Optimized Image cases, following
// https://github.com/GoogleCloudPlatform/compute-gpu-installation/blob/main/linux/install_gpu_driver.py.
bool install_gpu_drivers = 3;
}

Expand All @@ -377,20 +395,30 @@ message AllocationPolicy {
// You can specify the network as a full or partial URL.
//
// For example, the following are all valid URLs:
//
// * https://www.googleapis.com/compute/v1/projects/{project}/global/networks/{network}
// * projects/{project}/global/networks/{network}
// * global/networks/{network}
// <pre><code>https://www.googleapis.com/compute/v1/projects/<var
// class="apiparam">project</var>/global/networks/<var
// class="apiparam">network</var></code></pre>
// <pre><code>projects/<var
// class="apiparam">project</var>/global/networks/<var
// class="apiparam">network</var></code></pre>
// <pre><code>global/networks/<var
// class="apiparam">network</var></code></pre>
string network = 1;

// The URL of an existing subnetwork resource in the network.
// You can specify the subnetwork as a full or partial URL.
//
// For example, the following are all valid URLs:
//
// * https://www.googleapis.com/compute/v1/projects/{project}/regions/{region}/subnetworks/{subnetwork}
// * projects/{project}/regions/{region}/subnetworks/{subnetwork}
// * regions/{region}/subnetworks/{subnetwork}
// <pre><code>https://www.googleapis.com/compute/v1/projects/<var
// class="apiparam">project</var>/regions/<var
// class="apiparam">region</var>/subnetworks/<var
// class="apiparam">subnetwork</var></code></pre>
// <pre><code>projects/<var class="apiparam">project</var>/regions/<var
// class="apiparam">region</var>/subnetworks/<var
// class="apiparam">subnetwork</var></code></pre>
// <pre><code>regions/<var
// class="apiparam">region</var>/subnetworks/<var
// class="apiparam">subnetwork</var></code></pre>
string subnetwork = 2;

// Default is false (with an external IP address). Required if
Expand Down

0 comments on commit c34b78b

Please sign in to comment.