chore: NPE in testConnectionClose (#2072)

* Added a not null assertion for connection in testConnectionClose * Added testCreateDefaultConnection
googleapis · May 26, 2022 · 51694d8 · 51694d8
1 parent 4e153f5
commit 51694d8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java
@@ -2724,6 +2724,15 @@ public void testReadAPIIterationAndOrder()
     connection.close();
   }
 
+  // Ref: https://github.com/googleapis/java-bigquery/issues/2070. Adding a pre-submit test to see
+  // if bigquery.createConnection() returns null
+  @Test
+  public void testCreateDefaultConnection() throws BigQuerySQLException {
+    Connection connection = bigquery.createConnection();
+    assertNotNull("bigquery.createConnection() returned null", connection);
+    assertTrue(connection.close());
+  }
+
   @Test
   public void testReadAPIConnectionMultiClose()
       throws

diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITNightlyBigQueryTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITNightlyBigQueryTest.java
@@ -341,6 +341,7 @@ public void testIterateAndOrderDefaultConnSettings() throws SQLException {
   @Test
   public void testConnectionClose() throws SQLException {
     Connection connection = bigquery.createConnection();
+    assertNotNull("bigquery.createConnection() returned null", connection);
     BigQueryResult bigQueryResult = connection.executeSelect(QUERY);
     logger.log(Level.INFO, "Query used: {0}", QUERY);
     ResultSet rs = bigQueryResult.getResultSet();