feat: return JobID with TableResult #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Neenu1995
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Neenu1995
added
the
kokoro:force-run
Neenu1995
changed the title
Neenu1995
changed the title
Neenu1995
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
product-auto-label
bot
added
size: m
Neenu1995
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Neenu1995
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Neenu1995
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
Neenu1995
removed
the
automerge
Neenu1995
changed the title
|
@shollyman PTAL. |
shollyman
reviewed
Jun 12, 2023
google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQueryImpl.java
Outdated
Show resolved
Hide resolved
shollyman
approved these changes
Jun 14, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 19, 2023
🤖 I have created a release *beep* *boop* --- ## [2.28.0](https://togithub.com/googleapis/java-bigquery/compare/v2.27.1...v2.28.0) (2023-06-19) ### Features * Add primary key and foreign keys ([#2744](https://togithub.com/googleapis/java-bigquery/issues/2744)) ([afb571c](https://togithub.com/googleapis/java-bigquery/commit/afb571c97edb13f93df9ac140af4516205d27a49)) * Partial Projection of Table Metadata ([#2756](https://togithub.com/googleapis/java-bigquery/issues/2756)) ([9207743](https://togithub.com/googleapis/java-bigquery/commit/92077437d759705151f7778207616ecf024371ba)) * Return JobID with TableResult ([#2689](https://togithub.com/googleapis/java-bigquery/issues/2689)) ([aa38428](https://togithub.com/googleapis/java-bigquery/commit/aa38428ad26b64d2566b33f4b2ca3dcc102c3247)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This was referenced Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no easy way to log the successful JobID after the job has been completed. Prompting customers to pass their own jobIDs for the query method. If the JobID is returned with the result of the query method, customers don’t have to pass the explicit JobID anymore, enabling more customers to use the fast query path.
Query method returns a TableResult object. Adding a JobID field to the TableResult could convince customers to use the query method overload without passing explicit JobID.