Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add BigLakeConfiguration Property in StandardTableDefinition.java #2916

Merged
merged 9 commits into from Oct 12, 2023

Conversation

vteja11
Copy link
Contributor

@vteja11 vteja11 commented Sep 29, 2023

The Spark Bigquery connector uses the java-bigquery library to communicate with BigQuery. In some cases, we need to determine if a table is a Biglake table. A table is identified as a Biglake table if it has the BigLakeConfiguration property. Therefore, we need to propagate the BigLakeConfiguration property from the Table class to the StandardTableDefinition class.

Fixes #2915 ☕️

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Sep 29, 2023
@vteja11 vteja11 changed the title Added BigLakeConfiguration in standard table defenition feat: Add BigLakeConfiguration Property in StandardTableDefinition.java Sep 29, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@vteja11 vteja11 marked this pull request as ready for review October 2, 2023 05:19
@vteja11 vteja11 requested a review from a team as a code owner October 2, 2023 05:19
@vteja11 vteja11 requested a review from shollyman October 2, 2023 05:19
obada-ab
obada-ab previously approved these changes Oct 2, 2023
@@ -0,0 +1,123 @@
/*
* Copyright 2016 Google LLC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: copyright dates

@obada-ab obada-ab dismissed their stale review October 2, 2023 15:31

some checks are unsuccessful

@obada-ab
Copy link
Member

obada-ab commented Oct 2, 2023

@vteja11 to resolve the clirr error, please add an entry to https://github.com/googleapis/java-bigquery/blob/main/google-cloud-bigquery/clirr-ignored-differences.xml

The entry would be something like this:

  <difference>
    <differenceType>7013</differenceType>
    <className>com/google/cloud/bigquery/StandardTableDefinition*</className>
    <method>*BiglakeConfiguration(*)</method>
  </difference>

@vteja11
Copy link
Contributor Author

vteja11 commented Oct 2, 2023

@obada-ab @shollyman
Could i know when the next release is ? Because i need to make changes in other clients (spark-bigquery connector) using this dependency

@vteja11 vteja11 requested a review from a team as a code owner October 2, 2023 20:52
@obada-ab
Copy link
Member

obada-ab commented Oct 3, 2023

@obada-ab @shollyman Could i know when the next release is ? Because i need to make changes in other clients (spark-bigquery connector) using this dependency

Next release should be in around 1-2 weeks

@obada-ab obada-ab added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
@obada-ab obada-ab added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@obada-ab obada-ab added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 9, 2023
@obada-ab obada-ab added the automerge Merge the pull request once unit tests and other checks pass. label Oct 9, 2023
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 9, 2023
@vteja11
Copy link
Contributor Author

vteja11 commented Oct 11, 2023

@obada-ab i see that PR was not able to merge, does every reviewer needs to approve this ? If so @shollyman can you please approve this ?

@obada-ab obada-ab added the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2023
@obada-ab obada-ab merged commit 1d660fa into googleapis:main Oct 12, 2023
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 26, 2023
🤖 I have created a release *beep* *boop*
---


## [2.34.0](https://togithub.com/googleapis/java-bigquery/compare/v2.33.2...v2.34.0) (2023-10-26)


### Features

* Add BigLakeConfiguration Property in StandardTableDefinition.java  ([#2916](https://togithub.com/googleapis/java-bigquery/issues/2916)) ([1d660fa](https://togithub.com/googleapis/java-bigquery/commit/1d660fa19f0d82c2b6ec2ea9590881e513274c25))
* Add support for Dataset property storageBillingModel ([#2913](https://togithub.com/googleapis/java-bigquery/issues/2913)) ([f452cf4](https://togithub.com/googleapis/java-bigquery/commit/f452cf4e100b6cc211681a840ddbd0be5108d01e))
* Add support for preview features ([#2923](https://togithub.com/googleapis/java-bigquery/issues/2923)) ([113b8f2](https://togithub.com/googleapis/java-bigquery/commit/113b8f27419365c7277c6a300c5f07cea954cca1))


### Dependencies

* Update actions/checkout action to v4.1.1 ([#2950](https://togithub.com/googleapis/java-bigquery/issues/2950)) ([c556c18](https://togithub.com/googleapis/java-bigquery/commit/c556c1837baf0d53245452d6a152910df7883262))
* Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.30.0 ([#2942](https://togithub.com/googleapis/java-bigquery/issues/2942)) ([e760fca](https://togithub.com/googleapis/java-bigquery/commit/e760fcae98b23ff4e7fc3ae25f2437be220e9df9))
* Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.31.0 ([#2967](https://togithub.com/googleapis/java-bigquery/issues/2967)) ([7ed55b5](https://togithub.com/googleapis/java-bigquery/commit/7ed55b5c075dbac827c6201d0398ff87d8240b38))
* Update dependency com.google.apis:google-api-services-bigquery to v2-rev20231008-2.0.0 ([#2946](https://togithub.com/googleapis/java-bigquery/issues/2946)) ([3d0da5b](https://togithub.com/googleapis/java-bigquery/commit/3d0da5b5a20f49721477afbed10ea3fff43652bb))
* Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.34.0 ([#2943](https://togithub.com/googleapis/java-bigquery/issues/2943)) ([18162c3](https://togithub.com/googleapis/java-bigquery/commit/18162c37c97eff6387e0f58d211f2c1725a9c8d3))
* Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.35.0 ([#2968](https://togithub.com/googleapis/java-bigquery/issues/2968)) ([219db2c](https://togithub.com/googleapis/java-bigquery/commit/219db2c0023610d2adcba4889a9b785df2113893))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.18.0 ([#2955](https://togithub.com/googleapis/java-bigquery/issues/2955)) ([1ee18eb](https://togithub.com/googleapis/java-bigquery/commit/1ee18ebeb90adeb371ef04cbfc7b18be2c24d1e8))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.28 ([#2956](https://togithub.com/googleapis/java-bigquery/issues/2956)) ([b03effd](https://togithub.com/googleapis/java-bigquery/commit/b03effd3b5f5fd6365de9a6267a1a8ace46d7718))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.28 ([#2957](https://togithub.com/googleapis/java-bigquery/issues/2957)) ([6465e41](https://togithub.com/googleapis/java-bigquery/commit/6465e413c93e01069f86c80fc424715d46f9067b))
* Update github/codeql-action action to v2.22.2 ([#2944](https://togithub.com/googleapis/java-bigquery/issues/2944)) ([f584e59](https://togithub.com/googleapis/java-bigquery/commit/f584e59571f0c7918d2d83a19b00d49bd5b558c4))
* Update github/codeql-action action to v2.22.3 ([#2954](https://togithub.com/googleapis/java-bigquery/issues/2954)) ([1b2bc18](https://togithub.com/googleapis/java-bigquery/commit/1b2bc18bf49d06e1ccd29745be649108dd28cfa5))
* Update github/codeql-action action to v2.22.4 ([#2958](https://togithub.com/googleapis/java-bigquery/issues/2958)) ([de9bcee](https://togithub.com/googleapis/java-bigquery/commit/de9bcee50ba682ffa93aae063191a8880741507d))
* Update ossf/scorecard-action action to v2.3.1 ([#2960](https://togithub.com/googleapis/java-bigquery/issues/2960)) ([855e698](https://togithub.com/googleapis/java-bigquery/commit/855e69889f68592608c8a56070ffdafdf8365f57))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BigLakeConfiguration as a property of StandardTableDefinition
4 participants