Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multiplexing client core algorithm and basic testing, plus fix a tiny bug in fake server #1787

Merged
merged 16 commits into from Sep 20, 2022
Merged

feat: add multiplexing client core algorithm and basic testing, plus fix a tiny bug in fake server #1787

merged 16 commits into from Sep 20, 2022

Conversation

GaoleMeng
Copy link
Contributor

@GaoleMeng GaoleMeng commented Sep 19, 2022 •
edited

Note:

  1. This is simplified from internal version as it turns out the connections count to up scale each time is ok to set to 1 as constant.
  2. The fake server is not respecting offset, let's change that
  3. No random k is needed as we have a pretty low upper bound for connections count

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

GaoleMeng and others added 14 commits September 13, 2022 01:58
@GaoleMeng
feat: Split writer into connection worker and wrapper, this is a
5a63d95 
prerequisite for multiplexing client
@GaoleMeng
feat: add connection worker pool skeleton, used for multiplexing client
5a13302
@GaoleMeng
Merge branch 'main' into main
0297204
@GaoleMeng
feat: add Load api for connection worker for multiplexing client
8a81ad3
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
68fd040
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
3106dae
@GaoleMeng
Merge branch 'googleapis:main' into main
5bf04e5
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
2fc7551
@GaoleMeng
feat: add multiplexing support to connection worker. We will treat every
7a6d919 
new stream name as a switch of destinationt
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
3ba7659 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot @GaoleMeng
Updates from OwlBot post-processor
f379a78 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
9307776
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
de73013 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
feat: port the multiplexing client core algorithm and basic tests
19005a1 
also fixed a tiny bug inside fake bigquery write impl for getting thre
response from offset
@GaoleMeng GaoleMeng requested review from a team and shollyman September 19, 2022 19:23
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Sep 19, 2022
@GaoleMeng GaoleMeng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2022
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner September 20, 2022 00:54
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@GaoleMeng GaoleMeng merged commit 1bb8e26 into googleapis:main Sep 20, 2022
@release-please release-please bot mentioned this pull request Sep 20, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 30, 2022
@release-please
chore(main): release 2.22.0 (#1785)
935d7a8 
🤖 I have created a release *beep* *boop*
---


## [2.22.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.21.0...v2.22.0) (2022-09-29)


### Features

* Add a new specific exception about json data has unknown field ([#1792](https://togithub.com/googleapis/java-bigquerystorage/issues/1792)) ([18f93c1](https://togithub.com/googleapis/java-bigquerystorage/commit/18f93c124334464a951b3d3065bdf11bbda13dac))
* Add cache for location in stream writer, and trigger that when location is not presented ([#1804](https://togithub.com/googleapis/java-bigquerystorage/issues/1804)) ([c24c14f](https://togithub.com/googleapis/java-bigquerystorage/commit/c24c14f14b1a6f8249f55630d51e3cadd500c1ad))
* Add close() to multiplexing client ([#1788](https://togithub.com/googleapis/java-bigquerystorage/issues/1788)) ([6b3a974](https://togithub.com/googleapis/java-bigquerystorage/commit/6b3a97491bf718333ae7c085f9b10723d8b24388))
* Add fully managed schema support on json writer ([#1794](https://togithub.com/googleapis/java-bigquerystorage/issues/1794)) ([b6b515f](https://togithub.com/googleapis/java-bigquerystorage/commit/b6b515f57a0f6956c9d9f902a5e3e16edc845a48))
* Add more retry error code to the sample ([#1805](https://togithub.com/googleapis/java-bigquerystorage/issues/1805)) ([4bf67bc](https://togithub.com/googleapis/java-bigquerystorage/commit/4bf67bcf0de2d370f0b04d8df236d30466b91598))
* Add multiplexing client core algorithm and basic testing, plus fix a tiny bug in fake server ([#1787](https://togithub.com/googleapis/java-bigquerystorage/issues/1787)) ([1bb8e26](https://togithub.com/googleapis/java-bigquerystorage/commit/1bb8e262941f570d7f2de60123ec5a6a0cf43600))
* Add multiplexing support to connection worker.  ([#1784](https://togithub.com/googleapis/java-bigquerystorage/issues/1784)) ([a869a1d](https://togithub.com/googleapis/java-bigquerystorage/commit/a869a1d8baba3cc0f6046d661c6f52ec12a3f12d))
* Add support for flexible column name in JsonStreamWriter ([#1786](https://togithub.com/googleapis/java-bigquerystorage/issues/1786)) ([694abbb](https://togithub.com/googleapis/java-bigquerystorage/commit/694abbb43bf2970cd81803521c349dc31a38f484))
* Add two fine logs that would allow Datastream to look into the stuck issue ([#1791](https://togithub.com/googleapis/java-bigquerystorage/issues/1791)) ([745ceb4](https://togithub.com/googleapis/java-bigquerystorage/commit/745ceb46dec5922efe394773028532dcd84a4f9b))
* Always pass a null bigquery client lib to StreamWriter ([#1795](https://togithub.com/googleapis/java-bigquerystorage/issues/1795)) ([eec50c1](https://togithub.com/googleapis/java-bigquerystorage/commit/eec50c14e1dff84ae9a3e70f9d08d27b9e225e55))
* Bug fix for checking write_stream field but proto might not contain the field to unblock the release ([#1806](https://togithub.com/googleapis/java-bigquerystorage/issues/1806)) ([9791d69](https://togithub.com/googleapis/java-bigquerystorage/commit/9791d693c75367bec6451ebf65ae4ea3347bf50f))
* Client unknown fields drives writer refreshment ([#1797](https://togithub.com/googleapis/java-bigquerystorage/issues/1797)) ([d8aaed5](https://togithub.com/googleapis/java-bigquerystorage/commit/d8aaed522b9de487539165ea662465e5a96222f1))
* ExecutorProvider can now be replaced ([#1770](https://togithub.com/googleapis/java-bigquerystorage/issues/1770)) ([6380f71](https://togithub.com/googleapis/java-bigquerystorage/commit/6380f713b8f42fa3a58df2750ea2cf3b7397d29c)), closes [#1769](https://togithub.com/googleapis/java-bigquerystorage/issues/1769)
* Fix some todos and reject stream writer if it's created with mixed behavior of passed in client or not ([#1803](https://togithub.com/googleapis/java-bigquerystorage/issues/1803)) ([1a69192](https://togithub.com/googleapis/java-bigquerystorage/commit/1a69192e2ffc6475a7e4b67c5a452f1c0e8aaddc))
* Minor tune after offline testing  ([#1807](https://togithub.com/googleapis/java-bigquerystorage/issues/1807)) ([694a870](https://togithub.com/googleapis/java-bigquerystorage/commit/694a870bac623ef038168a4358b9d73972077edb))
* Populate location info if we already called GetWriteStream ([#1802](https://togithub.com/googleapis/java-bigquerystorage/issues/1802)) ([5f43103](https://togithub.com/googleapis/java-bigquerystorage/commit/5f4310321e7f90385f7ef5c32e3e5395f719d0ca))
* Some fixes for multiplexing client  ([#1798](https://togithub.com/googleapis/java-bigquerystorage/issues/1798)) ([b3ffd77](https://togithub.com/googleapis/java-bigquerystorage/commit/b3ffd77e4b86708f241ba517c55bb3508964bc0e))
* Wire connection pool to stream writer without implementing updated schema  ([#1790](https://togithub.com/googleapis/java-bigquerystorage/issues/1790)) ([3eb1475](https://togithub.com/googleapis/java-bigquerystorage/commit/3eb147545db2415e5a68752b8ede1c4d342d1a84))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request Apr 4, 2023
@gcf-owl-bot
chore: make exception for non-cloud artifacts (#1787)
2fed8ed 
* bugfix: make exception for non-cloud artifacts

* change format
Source-Link: googleapis/synthtool@a86e189
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:944c07e458ce227ca49a423affedf088e31e2ee70908dd21682238d58f1beb60
Neenu1995 pushed a commit that referenced this pull request Apr 13, 2023
@gcf-owl-bot
chore: make exception for non-cloud artifacts (#1787) (#2075)
0d1b827 
* bugfix: make exception for non-cloud artifacts

* change format
Source-Link: googleapis/synthtool@a86e189
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:944c07e458ce227ca49a423affedf088e31e2ee70908dd21682238d58f1beb60

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GaoleMeng @yirutang @yoshi-kokoro