Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change one thread per retry to use a thread pool #1898

Merged
merged 51 commits into from Nov 30, 2022
Merged

feat: Change one thread per retry to use a thread pool #1898

merged 51 commits into from Nov 30, 2022

Conversation

GaoleMeng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

GaoleMeng and others added 30 commits September 13, 2022 01:58
@GaoleMeng
feat: Split writer into connection worker and wrapper, this is a
5a63d95 
prerequisite for multiplexing client
@GaoleMeng
feat: add connection worker pool skeleton, used for multiplexing client
5a13302
@GaoleMeng
Merge branch 'main' into main
0297204
@GaoleMeng
feat: add Load api for connection worker for multiplexing client
8a81ad3
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
68fd040
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
3106dae
@GaoleMeng
Merge branch 'googleapis:main' into main
5bf04e5
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
2fc7551
@GaoleMeng
feat: add multiplexing support to connection worker. We will treat every
7a6d919 
new stream name as a switch of destinationt
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
3ba7659 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot @GaoleMeng
Updates from OwlBot post-processor
f379a78 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
9307776
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
de73013 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
feat: port the multiplexing client core algorithm and basic tests
19005a1 
also fixed a tiny bug inside fake bigquery write impl for getting thre
response from offset
@GaoleMeng
Merge branch 'googleapis:main' into main
c5d14ba
@gcf-owl-bot @GaoleMeng
🦉 Updates from OwlBot post-processor
644360a 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'googleapis:main' into main
3099d82
@GaoleMeng
Merge branch 'googleapis:main' into main
e707dd6
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
9e7a8fa
@GaoleMeng
Merge branch 'googleapis:main' into main
31f1755
@GaoleMeng
feat: wire multiplexing connection pool to stream writer
44c36fc
@GaoleMeng
feat: some fixes for multiplexing client
87a4036
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
c92ea1b
@GaoleMeng
Merge branch 'googleapis:main' into main
019520c
@GaoleMeng
feat: fix some todos, and reject the mixed behavior of passed in clie…
47893df 
…nt or not
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
8bd4e6a
@GaoleMeng
Merge remote-tracking branch 'upstream/main'
83409b0
@GaoleMeng
Merge branch 'googleapis:main' into main
f7dd72d
@GaoleMeng
Merge branch 'googleapis:main' into main
a48399f
@GaoleMeng
feat: fix the bug that we may peek into the write_stream field but it's
6789bc9 
possible the proto schema does not contain this field
GaoleMeng and others added 18 commits September 29, 2022 13:17
@GaoleMeng
Merge branch 'googleapis:main' into main
dfd4dd9
@GaoleMeng
feat: fix the bug that we may peek into the write_stream field but it's
d68ae70 
possible the proto schema does not contain this field
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
2983fe9
@GaoleMeng
Merge branch 'googleapis:main' into main
d406256
@GaoleMeng
feat: add getInflightWaitSeconds implementation
22e9e07
@GaoleMeng
Merge branch 'googleapis:main' into main
fdb4e1c
@GaoleMeng
Merge branch 'googleapis:main' into main
0469474
@GaoleMeng
feat: Add schema comparision in connection loop to ensure schema upda…
d1b7740 
…te for

the same stream name can be notified
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
e4cd529 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'googleapis:main' into main
74ff1c4
@GaoleMeng
feat: add schema update support to multiplexing
762f49e
@GaoleMeng
Merge branch 'googleapis:main' into main
de456c2
@GaoleMeng
Merge branch 'googleapis:main' into main
c2f6edc
@GaoleMeng
fix: fix windows build bug: windows Instant resolution is different with
2487227 
linux
@GaoleMeng
fix: fix another failing tests for windows build
084d6d1
@GaoleMeng
Merge branch 'main' of https://github.com/GaoleMeng/java-bigquerystorage
89c9701
@GaoleMeng
fix: fix another test failure for Windows build
8441518
@GaoleMeng
Merge branch 'googleapis:main' into main
d249add
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Nov 30, 2022
@GaoleMeng GaoleMeng changed the title Change one thread per retry to use a thread pool feat: Change one thread per retry to use a thread pool Nov 30, 2022
@GaoleMeng
feat: Change new thread for each retry to be a thread pool to avoid
83aa7ff 
create/tear down too much threads if lots of retries happens
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2022
@GaoleMeng GaoleMeng merged commit 44a4e4d into googleapis:main Nov 30, 2022
@release-please release-please bot mentioned this pull request Dec 12, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 12, 2022
@release-please
chore(main): release 2.27.0 (#1908)
4dd8968 
🤖 I have created a release *beep* *boop*
---


## [2.27.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.26.0...v2.27.0) (2022-12-12)


### Features

* Change one thread per retry to use a thread pool  ([#1898](https://togithub.com/googleapis/java-bigquerystorage/issues/1898)) ([44a4e4d](https://togithub.com/googleapis/java-bigquerystorage/commit/44a4e4d8c70bf910f96d2d2c181d1f23b70f3e52))
* Throw error when using connection pool for explicit stream ([#1903](https://togithub.com/googleapis/java-bigquerystorage/issues/1903)) ([bd89556](https://togithub.com/googleapis/java-bigquerystorage/commit/bd895567fe33735294065d7043d845f14f33f8a8))


### Bug Fixes

* Add back the accidentally removed background executor provider  ([#1899](https://togithub.com/googleapis/java-bigquerystorage/issues/1899)) ([065cc4f](https://togithub.com/googleapis/java-bigquerystorage/commit/065cc4f35ad5e5cdc393e01adbea881c6e92dcab))
* Update JsonStreamWriterBuilder comment and update sample to use the latest schema retrieval support ([#1902](https://togithub.com/googleapis/java-bigquerystorage/issues/1902)) ([2a46ec3](https://togithub.com/googleapis/java-bigquerystorage/commit/2a46ec3df419bbeba6a2e60b2b621dc60f31eab1))


### Dependencies

* Update arrow.version to v10.0.1 ([#1894](https://togithub.com/googleapis/java-bigquerystorage/issues/1894)) ([8e90767](https://togithub.com/googleapis/java-bigquerystorage/commit/8e907677bae0c48e8c64be5cbab8fb203645f4ef))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.1.0 ([#1905](https://togithub.com/googleapis/java-bigquerystorage/issues/1905)) ([767be03](https://togithub.com/googleapis/java-bigquerystorage/commit/767be035defbcc5b77f1276bb1a2983b6a7423bd))
* Update dependency org.apache.arrow:arrow-memory-netty to v10.0.1 ([#1895](https://togithub.com/googleapis/java-bigquerystorage/issues/1895)) ([8b079cc](https://togithub.com/googleapis/java-bigquerystorage/commit/8b079cc47ca914756bd73dda98bd15393754ebb1))
* Update dependency org.apache.arrow:arrow-vector to v10.0.1 ([#1896](https://togithub.com/googleapis/java-bigquerystorage/issues/1896)) ([087ac6e](https://togithub.com/googleapis/java-bigquerystorage/commit/087ac6e7ad813dc248e9029f91c454299a87b2b3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GaoleMeng @yirutang