Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: correct AppendSerializtionError typo #1901

Closed
wants to merge 6 commits into from
Closed

fix!: correct AppendSerializtionError typo #1901

wants to merge 6 commits into from

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Dec 1, 2022 •
edited

BREAKING CHANGE: customers need to update their code to fix build errors.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@yirutang yirutang requested a review from a team December 1, 2022 21:00
@yirutang yirutang requested a review from a team as a code owner December 1, 2022 21:00
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Dec 1, 2022
@yirutang yirutang changed the title break: fix AppendserializationError typo break: fix AppendSerializtionError typo Dec 1, 2022
@yirutang yirutang changed the title break: fix AppendSerializtionError typo BREAKING CHANGE: fix AppendSerializtionError typo Dec 1, 2022
@yirutang yirutang changed the title BREAKING CHANGE: fix AppendSerializtionError typo fix!: correct AppendSerializtionError typo Dec 1, 2022
@Neenu1995
Copy link
Contributor

This breaking change will be included in the 2023 major version update.

@Neenu1995 Neenu1995 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 2, 2022
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2022
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 2, 2022
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 2, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 2, 2022
@Neenu1995
Copy link
Contributor

Merge #2037 instead

@Neenu1995 Neenu1995 closed this Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yirutang @Neenu1995 @yoshi-kokoro