Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update SchemaAwareStreamWriter comment to down recommend it. #2195

Merged
merged 6 commits into from Jul 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -43,6 +43,13 @@
* StreamWriter functions, but also provides an additional feature: schema update support, where if
* the BigQuery table schema is updated, users will be able to ingest data on the new schema after
* some time (in order of minutes).
*
* <p>NOTE: The schema update ability will be disabled when you pass in a table schema explicitly
* through the writer. It is recommended that user either use JsonStreamWriter (which fully manages
* table schema) or StreamWriter (which accepts proto format in raw and user will handle the schema
* update event themsevles). If you use this class, you need to be very cautious about possible
* mistmach between the writer's schema and the input data, any mismatch of the two will cause data
yirutang marked this conversation as resolved.
Show resolved Hide resolved
* corruption.
yirutang marked this conversation as resolved.
Show resolved Hide resolved
*/
public class SchemaAwareStreamWriter<T> implements AutoCloseable {
private static final Logger LOG = Logger.getLogger(SchemaAwareStreamWriter.class.getName());
Expand Down