Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate tests off TextPrinter's deprecated methods #2506

Merged
merged 2 commits into from
May 24, 2024
Merged

chore: Migrate tests off TextPrinter's deprecated methods #2506

merged 2 commits into from
May 24, 2024

Conversation

lqiu96
Copy link
Contributor

@lqiu96 lqiu96 commented May 17, 2024

Part of the compatibility changes in #2505

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels May 17, 2024
@lqiu96
Copy link
Contributor Author

lqiu96 commented May 20, 2024

Error:

Error:  Errors: 
Error:    ConnectionWorkerPoolTest.testSingleTableConnection_noOverwhelmedConnection:97->testSendRequestsToMultiTable:206 » Execution com.google.cloud.bigquery.storage.v1.Exceptions$MaximumRequestCallbackWaitTimeExceededException: Request has waited in inflight queue for PT4.003924214Sms for writer 24455a3e-9628-4bc4-89c3-6a86a1b11233, which is over maximum wait time PT4S

@lqiu96
Copy link
Contributor Author

lqiu96 commented May 21, 2024

Error:

Error:  Errors: 
Error:    ConnectionWorkerPoolTest.testSingleTableConnection_noOverwhelmedConnection:97->testSendRequestsToMultiTable:206 » Execution com.google.cloud.bigquery.storage.v1.Exceptions$MaximumRequestCallbackWaitTimeExceededException: Request has waited in inflight queue for PT4.003924214Sms for writer 24455a3e-9628-4bc4-89c3-6a86a1b11233, which is over maximum wait time PT4S

It looks like this error message occurs in other PRs as well. This time exceeded exception issue is not related to my change.

@lqiu96 lqiu96 marked this pull request as ready for review May 21, 2024 15:41
@lqiu96 lqiu96 requested a review from a team as a code owner May 21, 2024 15:41
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 21, 2024
@lqiu96 lqiu96 requested a review from PhongChuong May 21, 2024 19:06
@lqiu96 lqiu96 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2024
@Neenu1995 Neenu1995 merged commit 8ea06a8 into main May 24, 2024
21 checks passed
@Neenu1995 Neenu1995 deleted the protobufjava-426x-compatibility branch May 24, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Neenu1995 approved these changes

@agrawal-siddharth agrawal-siddharth Awaiting requested review from agrawal-siddharth agrawal-siddharth is a code owner automatically assigned from googleapis/api-bigquery

@PhongChuong PhongChuong Awaiting requested review from PhongChuong

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lqiu96 @Neenu1995