feat: add logic in replication for handling rows/cells that may exceed thresholds #4315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
vermas2012
reviewed
Mar 28, 2024
.../src/main/java/com/google/cloud/bigtable/hbase/replication/CloudBigtableReplicationTask.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/cloud/bigtable/hbase/replication/CloudBigtableReplicationTask.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/cloud/bigtable/hbase/replication/CloudBigtableReplicationTask.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/cloud/bigtable/hbase/replication/CloudBigtableReplicationTask.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/google/cloud/bigtable/hbase/replication/CloudBigtableReplicationTask.java
Show resolved
Hide resolved
...d/bigtable/hbase/replication/configuration/HBaseToCloudBigtableReplicationConfiguration.java
Outdated
Show resolved
Hide resolved
| Assert.assertEquals(false, logAndSkipIncompatibleRowMutationsDoesNotExceedEqual); | ||
| Assert.assertEquals(true, logAndSkipIncompatibleRowMutationsExceeds); | ||
| } | ||
|
|
There was a problem hiding this comment.
Add a test that validates that ReplicationTask does indeed use the results of the VerifyRowMutationThresholds.
I think we should make VerifyRowMutationThresholds private and test that the task failed or succeeded and verify that the appropriate metrics were incremented.
...va/com/google/cloud/bigtable/hbase/replication/adapters/IncompatibleMutationAdapterTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding capabilities to replication library to control the shape of data as it is replicated to bigtable. the controls are disabled by default, and when enabled, allow users to filter rows and cells which may block replication. The configurations have unit tests as well have been run through a series of tests for a live deployment.