Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix attempt status tag for metrics #1477

Merged
merged 1 commit into from Oct 25, 2022
Merged

fix: fix attempt status tag for metrics #1477

merged 1 commit into from Oct 25, 2022

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Oct 25, 2022 •
edited

@mutianf mutianf requested a review from a team as a code owner October 25, 2022 20:34
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Oct 25, 2022
igorbernstein2
igorbernstein2 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2022
@mutianf mutianf merged commit e54cf7d into googleapis:main Oct 25, 2022
@mutianf mutianf deleted the fix_attempt branch October 25, 2022 20:54
@release-please release-please bot mentioned this pull request Oct 25, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 27, 2022
@release-please
chore(main): release 2.15.0 (#1457)
504c71c 
🤖 I have created a release *beep* *boop*
---


## [2.15.0](https://togithub.com/googleapis/java-bigtable/compare/v2.14.1...v2.15.0) (2022-10-26)


### Features

* Add apis for Mutation and RowMutationEntry ([#1454](https://togithub.com/googleapis/java-bigtable/issues/1454)) ([a86934f](https://togithub.com/googleapis/java-bigtable/commit/a86934f4f70e1998e7368688df8695a4bac7006e))


### Bug Fixes

* Catch all throwables so version mismatch won't hang the client ([#1402](https://togithub.com/googleapis/java-bigtable/issues/1402)) ([c03b8a4](https://togithub.com/googleapis/java-bigtable/commit/c03b8a4245beab7258b8ed8ec76153e6a0275211))
* Fix attempt status tag for metrics ([#1477](https://togithub.com/googleapis/java-bigtable/issues/1477)) ([e54cf7d](https://togithub.com/googleapis/java-bigtable/commit/e54cf7d61128049cea2817b409a8524636b4a6cf))
* Rename metric names to match the external name ([#1479](https://togithub.com/googleapis/java-bigtable/issues/1479)) ([28ca7c3](https://togithub.com/googleapis/java-bigtable/commit/28ca7c310d9a157529555ab6865f89802161443b))
* Set a longer timeout to wait for callbacks to be executed ([#1478](https://togithub.com/googleapis/java-bigtable/issues/1478)) ([0d9ff6a](https://togithub.com/googleapis/java-bigtable/commit/0d9ff6ab3bd5bf853f1d371312036b14c924ae5e))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.5.0 ([#1464](https://togithub.com/googleapis/java-bigtable/issues/1464)) ([d8e58a5](https://togithub.com/googleapis/java-bigtable/commit/d8e58a5d88de7ea249d7bc141f1ac65592088da6))
* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.6.0 ([#1476](https://togithub.com/googleapis/java-bigtable/issues/1476)) ([331dcfb](https://togithub.com/googleapis/java-bigtable/commit/331dcfbd06ab578cfe9673ca70cab1f6abd5ddcd))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#1470](https://togithub.com/googleapis/java-bigtable/issues/1470)) ([557a4fb](https://togithub.com/googleapis/java-bigtable/commit/557a4fbed77157c3ccfc3e84a0c952b647844f9b))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.15 ([#1462](https://togithub.com/googleapis/java-bigtable/issues/1462)) ([69540cb](https://togithub.com/googleapis/java-bigtable/commit/69540cb2df25d5fb716e81e7513930b01c310b72))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.16 ([#1467](https://togithub.com/googleapis/java-bigtable/issues/1467)) ([53599ca](https://togithub.com/googleapis/java-bigtable/commit/53599caa0f92bad1365adbc4b58a1dcb1e8a393e))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.15 ([#1463](https://togithub.com/googleapis/java-bigtable/issues/1463)) ([a6612f9](https://togithub.com/googleapis/java-bigtable/commit/a6612f90cd4a0ec9589ca797ff3a42d23478a6e6))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.16 ([#1468](https://togithub.com/googleapis/java-bigtable/issues/1468)) ([fe0ddb1](https://togithub.com/googleapis/java-bigtable/commit/fe0ddb1b183cfdf368c2387a645a613bbfd52a69))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
mutianf added a commit to mutianf/java-bigtable that referenced this pull request Nov 5, 2022
@mutianf
test: add a test for readrows tags for fix googleapis#1477
ee5ea42
mutianf added a commit to mutianf/java-bigtable that referenced this pull request Nov 5, 2022
@mutianf
test: add a test for fix googleapis#1477 and few other tests to incre…
a2edcc6 
…ase coverage
mutianf added a commit to mutianf/java-bigtable that referenced this pull request Nov 5, 2022
@mutianf
test: add a test for fix googleapis#1477 and few other tests to incre…
53489af 
…ase coverage
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 7, 2022
@mutianf
test: add a test for fix #1477 and few other tests to increase covera…
6d446fc 
…ge (#1499)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the [samples format](
https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mutianf @igorbernstein2