Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix StackOverflow in ChangeStreamStateMachine due to excessive mods #1648

Merged
merged 5 commits into from
Feb 24, 2023
Merged

fix: Fix StackOverflow in ChangeStreamStateMachine due to excessive mods #1648

merged 5 commits into from
Feb 24, 2023

Conversation

tengzhonger
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@tengzhonger tengzhonger requested a review from a team as a code owner February 24, 2023 04:14
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Feb 24, 2023
mutianf
mutianf approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@mutianf mutianf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with some nits

.../main/java/com/google/cloud/bigtable/data/v2/stub/changestream/ChangeStreamStateMachine.java Outdated Show resolved Hide resolved
.../main/java/com/google/cloud/bigtable/data/v2/stub/changestream/ChangeStreamStateMachine.java Outdated Show resolved Hide resolved
.../main/java/com/google/cloud/bigtable/data/v2/stub/changestream/ChangeStreamStateMachine.java Outdated Show resolved Hide resolved
.../main/java/com/google/cloud/bigtable/data/v2/stub/changestream/ChangeStreamStateMachine.java Show resolved Hide resolved
.../main/java/com/google/cloud/bigtable/data/v2/stub/changestream/ChangeStreamStateMachine.java Outdated Show resolved Hide resolved
.../main/java/com/google/cloud/bigtable/data/v2/stub/changestream/ChangeStreamStateMachine.java Outdated Show resolved Hide resolved
.../main/java/com/google/cloud/bigtable/data/v2/stub/changestream/ChangeStreamStateMachine.java Show resolved Hide resolved
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 24, 2023 16:28
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9e11106 into googleapis:main Feb 24, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 24, 2023
@release-please release-please bot mentioned this pull request Feb 24, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 2, 2023
@release-please
chore(main): release 2.20.0 (#1649)
261ffc2 
🤖 I have created a release *beep* *boop*
---


## [2.20.0](https://togithub.com/googleapis/java-bigtable/compare/v2.19.2...v2.20.0) (2023-03-02)


### Features

* Add getNewPartitions method to CloseStream for Bigtable ChangeStream ([#1655](https://togithub.com/googleapis/java-bigtable/issues/1655)) ([8847fed](https://togithub.com/googleapis/java-bigtable/commit/8847fed7f77ce4715c197ca1cfcc3108e0fa1004))
* Add new_partitions field for CloseStream for Cloud Bigtable ChangeStream ([#1654](https://togithub.com/googleapis/java-bigtable/issues/1654)) ([0e283bf](https://togithub.com/googleapis/java-bigtable/commit/0e283bff0a12f5e4da8b0975d4bd747229c3780c))


### Bug Fixes

* Fix StackOverflow in ChangeStreamStateMachine due to excessive mods ([#1648](https://togithub.com/googleapis/java-bigtable/issues/1648)) ([9e11106](https://togithub.com/googleapis/java-bigtable/commit/9e1110600dc64defcd9143753f45b5b8226aa339))
* Use org.threeten.bp.Duration for ReadChangeStreamQuery::heartbeatDura… ([#1652](https://togithub.com/googleapis/java-bigtable/issues/1652)) ([87261a9](https://togithub.com/googleapis/java-bigtable/commit/87261a977d6fc7877d7d253c67ea34c264f63f7c))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.13.0 ([#1656](https://togithub.com/googleapis/java-bigtable/issues/1656)) ([1c632ec](https://togithub.com/googleapis/java-bigtable/commit/1c632ec63987958e469e2b5861c29724c5cb8970))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.4.0 ([#1657](https://togithub.com/googleapis/java-bigtable/issues/1657)) ([c7a3e29](https://togithub.com/googleapis/java-bigtable/commit/c7a3e29dc717e2fa3d9b15f1ae9fb9f795d6f78a))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tengzhonger @mutianf