fix: if new_partitions is size 0, do not enforce size check #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
product-auto-label
bot
added
size: s
tonytanger
changed the title
Change-Id: I4e9b6507ff63df9f9ec9d57a0fc34e68e16f6e30
tonytanger
force-pushed
the
remove_new_partitions_check
branch
from
d905e4f
to
549e495
Compare
tonytanger
changed the title
mutianf
approved these changes
Mar 20, 2023
mutianf
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
mutianf
added
the
automerge
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green
bot
removed
the
automerge
kolea2
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
kolea2
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
🤖 I have created a release *beep* *boop* --- ## [2.20.1](https://togithub.com/googleapis/java-bigtable/compare/v2.20.0...v2.20.1) (2023-03-21) ### Bug Fixes * If new_partitions is size 0, do not enforce size check ([#1673](https://togithub.com/googleapis/java-bigtable/issues/1673)) ([07bcfd9](https://togithub.com/googleapis/java-bigtable/commit/07bcfd9a0967f781fb8e5e0d764654dbf7bcda91)) ### Dependencies * Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.14.0 ([#1668](https://togithub.com/googleapis/java-bigtable/issues/1668)) ([06f9615](https://togithub.com/googleapis/java-bigtable/commit/06f96156705a2a7897a31d11dad864afe94de693)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.5.0 ([#1670](https://togithub.com/googleapis/java-bigtable/issues/1670)) ([74cebf3](https://togithub.com/googleapis/java-bigtable/commit/74cebf3a5ab58f3fd3ae95583ba2421b733deda8)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not enforce new_partitions and change_stream_continuation_tokens to be the same size if new_partitions has size of 0 because Cloud Bigtable backend may not be updated to serve new_partitions field yet.
new_partitionsis a new field and the backend may not be serving this field.Change-Id: Id21c293b92c304f05b905ca8e8b3988b9241866e
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.