Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.10.1 #1767

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented May 25, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-shared-dependencies 3.9.0 -> 3.10.1 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners May 25, 2023 18:38
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 25, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2023
@renovate-bot renovate-bot changed the title deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.10.0 deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3.10.1 May 26, 2023
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-google-cloud-shared-dependencies-3.x branch from 1f38fcc to 7c65870 Compare May 26, 2023 00:31
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 26, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 26, 2023
@igorbernstein2
Copy link
Contributor

The conformance failure seems to be related to a bug in gax that has been present for awhile: gax doesnt seem to limit the deadline to the totalTimeout of RetrySettings for the first attempt.

Specifically for the settings of:
RetrySettings {
initialRpcDeadline: 1 minute,
totalTimeout: 10 secs
}

AttemptCallable will pull the timeout from attemptSettings from the outer retrying future:
https://github.com/googleapis/sdk-platform-java/blob/0a77c2adcd4269cc7faecac1ce61a1d59be2687e/gax-java/gax/src/main/java/com/google/api/gax/rpc/AttemptCallable.java#L73

Which will get the settings from RetryAlgroithm:
https://github.com/googleapis/sdk-platform-java/blob/0a77c2adcd4269cc7faecac1ce61a1d59be2687e/gax-java/gax/src/main/java/com/google/api/gax/retrying/BasicRetryingFuture.java#L80

Which gets it from ExponentialRetryAlgorithm:
https://github.com/googleapis/sdk-platform-java/blob/0a77c2adcd4269cc7faecac1ce61a1d59be2687e/gax-java/gax/src/main/java/com/google/api/gax/retrying/ExponentialRetryAlgorithm.java#L101

Which takes verbatim from RetrySettings

This is in stark difference to following attempts which limit it to the smalller of operation timeout and rpc timeout:
https://github.com/googleapis/sdk-platform-java/blob/0a77c2adcd4269cc7faecac1ce61a1d59be2687e/gax-java/gax/src/main/java/com/google/api/gax/retrying/ExponentialRetryAlgorithm.java#L136-L141

For the time being I'll update the conformance test runner to limit the rpc timeout. But in the future we should either validate that rpcTimeout < totalTimeout or take the minimum of the 2 in gax

…loud-google-cloud-shared-dependencies-3.x

Change-Id: Ie24aa8230d3dd2f8baf17ef9a980a98665dd06d8
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 30, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2023
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2023
@igorbernstein2 igorbernstein2 merged commit 901b88f into googleapis:main May 30, 2023
20 of 21 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request May 31, 2023
🤖 I have created a release *beep* *boop*
---


## [2.23.2](https://togithub.com/googleapis/java-bigtable/compare/v2.23.1...v2.23.2) (2023-05-30)


### Documentation

* **samples:** Add bigtable filter snippet ([#1762](https://togithub.com/googleapis/java-bigtable/issues/1762)) ([48a6ed0](https://togithub.com/googleapis/java-bigtable/commit/48a6ed028a56302d6dc6554b2ecdabc8fbdb68cf))
* **samples:** Remove client initialization as the snippets are not used standalone ([#1768](https://togithub.com/googleapis/java-bigtable/issues/1768)) ([a6ac97c](https://togithub.com/googleapis/java-bigtable/commit/a6ac97c08a851977a76e82fddb16690cff17a1fe))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.19.0 ([#1769](https://togithub.com/googleapis/java-bigtable/issues/1769)) ([956c851](https://togithub.com/googleapis/java-bigtable/commit/956c851b5d7dadb44c589a3f982e603d0a768105))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.10.1 ([#1767](https://togithub.com/googleapis/java-bigtable/issues/1767)) ([901b88f](https://togithub.com/googleapis/java-bigtable/commit/901b88f56c7b97bc08826604ed80120f07f04a64))
* Update dependency com.google.truth.extensions:truth-proto-extension to v1.1.4 ([#1770](https://togithub.com/googleapis/java-bigtable/issues/1770)) ([a94a522](https://togithub.com/googleapis/java-bigtable/commit/a94a522a1fa4c67245f1827d8f8137cbfdbd5a45))
* Update doclet version to v1.9.0 ([#1761](https://togithub.com/googleapis/java-bigtable/issues/1761)) ([a5d4215](https://togithub.com/googleapis/java-bigtable/commit/a5d42159643c652a9625fee620fe5ee8dee7fa2e))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants