Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set wait timeout and update default attempt timeout to 30 minutes #1779

Merged
merged 2 commits into from Jun 6, 2023
Merged

fix: set wait timeout and update default attempt timeout to 30 minutes #1779

merged 2 commits into from Jun 6, 2023

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Jun 6, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mutianf mutianf requested a review from a team as a code owner June 6, 2023 15:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 6, 2023
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 6, 2023 17:31
@gcf-merge-on-green gcf-merge-on-green bot merged commit 11019b8 into googleapis:main Jun 6, 2023
20 of 21 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 6, 2023
@release-please release-please bot mentioned this pull request Jun 6, 2023
Merged
@mutianf mutianf deleted the update-timeout branch June 6, 2023 18:04
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 8, 2023
@release-please
chore(main): release 2.23.3 (#1780)
0285425 
🤖 I have created a release *beep* *boop*
---


## [2.23.3](https://togithub.com/googleapis/java-bigtable/compare/v2.23.2...v2.23.3) (2023-06-08)


### Bug Fixes

* Set wait timeout and update default attempt timeout to 30 minutes ([#1779](https://togithub.com/googleapis/java-bigtable/issues/1779)) ([11019b8](https://togithub.com/googleapis/java-bigtable/commit/11019b87fe32b5b9c9f2d947ffd9191b56120381))


### Dependencies

* Update dependency com.google.cloud:google-cloud-monitoring-bom to v3.20.0 ([#1785](https://togithub.com/googleapis/java-bigtable/issues/1785)) ([8ddd370](https://togithub.com/googleapis/java-bigtable/commit/8ddd370bf747bcc7ad7ccb6f00cc5ef188fa3511))
* Update gapic-generator-java to 2.21.0 ([#1760](https://togithub.com/googleapis/java-bigtable/issues/1760)) ([05545f8](https://togithub.com/googleapis/java-bigtable/commit/05545f87692c05c22d17e431551b4a5f91475286))
* Update shared dependencies to 3.11.0 ([#1783](https://togithub.com/googleapis/java-bigtable/issues/1783)) ([96aaa2a](https://togithub.com/googleapis/java-bigtable/commit/96aaa2a5a5a70feeb8ff0fd20b9dfc4a8a464bb7))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@mcookhome
Copy link

mcookhome commented Jun 28, 2023 •
edited

hey @mutianf, sorry to come out of the woodwork, but when my team at work upgraded to use this version of java bigtable, all of our readRows retry settings (which were not respected before this version bump, surprisingly) started to be respected.

This caused an incident for us as we were unaware that our service was going to start respecting the timeouts. the only upgrade in the java cloud bom diff that seems relevant at all is the java bigtable diff, and this change seems somewhat related, but the retry settings we're seeing reflected don't really have much to do with this change.

Do you know any other changes that may have caused our bigtable readRows retry settings to begin to be respected? Thanks for any details you may provide!

@igorbernstein2
Copy link
Contributor

Hi @mcookhome,

The relevant change was here: googleapis/sdk-platform-java#1473. I apologize for the disruption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mutianf @mcookhome @igorbernstein2