Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a rare race condition in the row merger #1939

Merged
merged 2 commits into from Sep 29, 2023
Merged

fix: a rare race condition in the row merger #1939

merged 2 commits into from Sep 29, 2023

Conversation

igorbernstein2
Copy link
Contributor

This would manifest as a hang when iterating over a ServerStream from ReadRows

Change-Id: I74533c6714b40a68ec0ef81dadac747e10bee39d

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2
fix: a rare race condition in the row merger
8f16146 
This would manifest as a hang when iterating over a ServerStream from ReadRows

Change-Id: I74533c6714b40a68ec0ef81dadac747e10bee39d
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner September 28, 2023 20:45
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 28, 2023
@igorbernstein2 igorbernstein2 merged commit fccd710 into main Sep 29, 2023
21 checks passed
@igorbernstein2 igorbernstein2 deleted the reframing-race branch September 29, 2023 14:56
@release-please release-please bot mentioned this pull request Sep 29, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 29, 2023
@release-please
chore(main): release 2.27.3 (#1931)
c4fc489 
🤖 I have created a release *beep* *boop*
---


## [2.27.3](https://togithub.com/googleapis/java-bigtable/compare/v2.27.2...v2.27.3) (2023-09-29)


### Bug Fixes

* A rare race condition in the row merger ([#1939](https://togithub.com/googleapis/java-bigtable/issues/1939)) ([fccd710](https://togithub.com/googleapis/java-bigtable/commit/fccd7100578da3e2ee2a315c6e956c06dbf41668))


### Dependencies

* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.27 ([#1919](https://togithub.com/googleapis/java-bigtable/issues/1919)) ([56d6b40](https://togithub.com/googleapis/java-bigtable/commit/56d6b40b9f874ec4ad78618c1cf0d365ddc9276b))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.27 ([#1920](https://togithub.com/googleapis/java-bigtable/issues/1920)) ([ca1dd5b](https://togithub.com/googleapis/java-bigtable/commit/ca1dd5b258c7fa5cfd90811dc8b9492c19d1f104))
* Update gapic-generator-java to 2.26.0 ([#1936](https://togithub.com/googleapis/java-bigtable/issues/1936)) ([15cd486](https://togithub.com/googleapis/java-bigtable/commit/15cd4868ff807513914095a3758134eaa14f0ea3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@igorbernstein2 igorbernstein2 mentioned this pull request Oct 23, 2023
Closed
4 tasks
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Nov 3, 2023
@igorbernstein2 @gcf-owl-bot @mutianf
fix: a rare race condition in the row merger (googleapis#1939)
589662b 
* fix: a rare race condition in the row merger

This would manifest as a hang when iterating over a ServerStream from ReadRows

Change-Id: I74533c6714b40a68ec0ef81dadac747e10bee39d

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
mutianf added a commit that referenced this pull request Nov 6, 2023
@mutianf @igorbernstein2 @gcf-owl-bot
fix: a rare race condition in the row merger (#1939) (#1988)
31b084a 
* fix: a rare race condition in the row merger (#1939)

* fix: a rare race condition in the row merger

This would manifest as a hang when iterating over a ServerStream from ReadRows

Change-Id: I74533c6714b40a68ec0ef81dadac747e10bee39d

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Igor Bernstein <igorbernstein@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Nov 6, 2023
Merged
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Nov 8, 2023
@igorbernstein2 @gcf-owl-bot @mutianf
fix: a rare race condition in the row merger (googleapis#1939)
cb88b39 
* fix: a rare race condition in the row merger

This would manifest as a hang when iterating over a ServerStream from ReadRows

Change-Id: I74533c6714b40a68ec0ef81dadac747e10bee39d

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
mutianf added a commit that referenced this pull request Nov 8, 2023
@mutianf @igorbernstein2
@gcf-owl-bot @steveniemitz
fix: a rare race condition in the row merger (#1939) (#2002)
6de74f3 
* fix: a rare race condition in the row merger (#1939)

* fix: a rare race condition in the row merger

This would manifest as a hang when iterating over a ServerStream from ReadRows

Change-Id: I74533c6714b40a68ec0ef81dadac747e10bee39d

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Fix flaky metrics tests (#1865)

This fixes a few flaky unit tests that relied on `Thread.sleep` to ensure that all metrics processing was done.  Rather than using `Thread.sleep`, we can instead use an inline event queue in the OpenCensus stats component to execute all work inline, removing the need to wait for anything to finish.

---------

Co-authored-by: Igor Bernstein <igorbernstein@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Steven Niemitz <steve@niemi.tz>
@release-please release-please bot mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveniemitz steveniemitz steveniemitz approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igorbernstein2 @steveniemitz