Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: append version to the client name in client-side metrics. #2062

Merged

Conversation

rkaregar
Copy link
Member

@rkaregar rkaregar commented Jan 19, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed

Fixes #2061 ☕️

If you write sample code, please follow the samples format.

@rkaregar rkaregar requested review from a team as code owners January 19, 2024 23:33
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jan 19, 2024
@rkaregar rkaregar requested a review from a team as a code owner January 23, 2024 23:18
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jan 23, 2024
@rkaregar rkaregar changed the title Append version to the client name in client-side metrics. feat: append version to the client name in client-side metrics. Jan 24, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Jan 25, 2024
@mutianf mutianf added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 25, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 9a0cdc8 into googleapis:main Jan 25, 2024
21 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 25, 2024
@rkaregar rkaregar deleted the karegar-client-version-metrics branch January 25, 2024 20:29
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 25, 2024
🤖 I have created a release *beep* *boop*
---


## [2.32.0](https://togithub.com/googleapis/java-bigtable/compare/v2.31.0...v2.32.0) (2024-01-25)


### Features

* Append version to the client name in client-side metrics. ([#2062](https://togithub.com/googleapis/java-bigtable/issues/2062)) ([9a0cdc8](https://togithub.com/googleapis/java-bigtable/commit/9a0cdc8cb8e2c52fde403eb316d28bf99c55a1e7))


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.32.0 ([#2060](https://togithub.com/googleapis/java-bigtable/issues/2060)) ([c218ac3](https://togithub.com/googleapis/java-bigtable/commit/c218ac3571360c85171dac71b915ad6776d97589))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.23.0 ([#2076](https://togithub.com/googleapis/java-bigtable/issues/2076)) ([5d1079c](https://togithub.com/googleapis/java-bigtable/commit/5d1079c2d1ced39b656773ff17743cb4e08a6126))
* Update dependency com.google.truth.extensions:truth-proto-extension to v1.3.0 ([#2058](https://togithub.com/googleapis/java-bigtable/issues/2058)) ([1622a9f](https://togithub.com/googleapis/java-bigtable/commit/1622a9f34d6818952eb283eba01992dc48a9df25))
* Update shared dependencies ([#2056](https://togithub.com/googleapis/java-bigtable/issues/2056)) ([f73ba40](https://togithub.com/googleapis/java-bigtable/commit/f73ba4099b497a78f82a1ad61b91035380955c21))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Feb 6, 2024
…leapis#2062)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
- [ ] Rollback plan is reviewed and LGTMed

Fixes googleapis#2061 ☕️

If you write sample code, please follow the [samples format](
https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
mutianf pushed a commit to mutianf/java-bigtable that referenced this pull request Feb 6, 2024
🤖 I have created a release *beep* *boop*
---


## [2.32.0](https://togithub.com/googleapis/java-bigtable/compare/v2.31.0...v2.32.0) (2024-01-25)


### Features

* Append version to the client name in client-side metrics. ([googleapis#2062](https://togithub.com/googleapis/java-bigtable/issues/2062)) ([9a0cdc8](https://togithub.com/googleapis/java-bigtable/commit/9a0cdc8cb8e2c52fde403eb316d28bf99c55a1e7))


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.32.0 ([googleapis#2060](https://togithub.com/googleapis/java-bigtable/issues/2060)) ([c218ac3](https://togithub.com/googleapis/java-bigtable/commit/c218ac3571360c85171dac71b915ad6776d97589))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.23.0 ([googleapis#2076](https://togithub.com/googleapis/java-bigtable/issues/2076)) ([5d1079c](https://togithub.com/googleapis/java-bigtable/commit/5d1079c2d1ced39b656773ff17743cb4e08a6126))
* Update dependency com.google.truth.extensions:truth-proto-extension to v1.3.0 ([googleapis#2058](https://togithub.com/googleapis/java-bigtable/issues/2058)) ([1622a9f](https://togithub.com/googleapis/java-bigtable/commit/1622a9f34d6818952eb283eba01992dc48a9df25))
* Update shared dependencies ([googleapis#2056](https://togithub.com/googleapis/java-bigtable/issues/2056)) ([f73ba40](https://togithub.com/googleapis/java-bigtable/commit/f73ba4099b497a78f82a1ad61b91035380955c21))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass client version in client-side metrics
3 participants