New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create the backbone of counting errors per connection each minute. #2094

Merged

mutianf merged 23 commits into googleapis:main from rkaregar:karegar-per-connection-error-counter

Feb 16, 2024

Member

rkaregar commented Feb 2, 2024 •

edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Rollback plan is reviewed and LGTMed

Fixes #2093 ☕️

Internal document about the feature: https://docs.google.com/document/d/1XPKdjV1sM80pc1ptaUW9B_WDXfdO-v69jCCRPI6aLPI

If you write sample code, please follow the samples format.


          Create the backbone of counting errors per connection each minute.

ac7363d

rkaregar requested review from a team as code owners

February 2, 2024 19:03

product-auto-label bot added the size: m label

conventional-commit-lint-gcf bot commented Feb 2, 2024 •

edited

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

product-auto-label bot added the api: bigtable label

mutianf reviewed

View reviewed changes

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved

mutianf reviewed

View reviewed changes

...cloud-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/StatsRecorderWrapper.java Outdated Show resolved Hide resolved

...cloud-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/StatsRecorderWrapper.java Outdated Show resolved Hide resolved

...cloud-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/StatsRecorderWrapper.java Outdated Show resolved Hide resolved

google-cloud-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/StatsWrapper.java Outdated Show resolved Hide resolved

mutianf reviewed

View reviewed changes

...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/ConnectionErrorCountInterceptor.java Outdated Show resolved Hide resolved


          Clean up creating new interceptors and StatsRecorderWrapper ctor.

1f26796

mutianf reviewed

View reviewed changes

...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/CountErrorsPerInterceptorTask.java Outdated Show resolved Hide resolved

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved


          Rename setting background task and fix imports.

a82f332

mutianf reviewed

View reviewed changes

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved

rkaregar added 2 commits

February 6, 2024 10:20


          Temporarily skip exporting per connection metrics to fix test failures.

0c0ae00


          Temporarily share the tests for debugging purposes

2a09449

product-auto-label bot added size: l and removed size: m labels

rkaregar added 5 commits

February 6, 2024 17:28


          Temporarily add the test for debugging.

b986073


          Remove the new ExecutorProvider and fix integration test failures.

c254251


          Update unit tests to reflect the new setup.

7c149ed


          Clean up and add tests.

69e693f


          Clean comments and add a TODO.

9f6e964

mutianf reviewed

View reviewed changes

...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/CountErrorsPerInterceptorTask.java Outdated Show resolved Hide resolved

...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/CountErrorsPerInterceptorTask.java Outdated Show resolved Hide resolved

...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/CountErrorsPerInterceptorTask.java Outdated Show resolved Hide resolved

...gtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/ErrorCountPerConnectionTest.java Outdated Show resolved Hide resolved

...gtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/ErrorCountPerConnectionTest.java Outdated Show resolved Hide resolved


          Improve tests and comments.

92fd9ea

mutianf approved these changes

View reviewed changes

igorbernstein2 requested changes

View reviewed changes

...cloud-bigtable-stats/src/main/java/com/google/cloud/bigtable/stats/StatsRecorderWrapper.java Outdated Show resolved Hide resolved

...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/ConnectionErrorCountInterceptor.java Outdated Show resolved Hide resolved

...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/CountErrorsPerInterceptorTask.java Outdated Show resolved Hide resolved

...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/CountErrorsPerInterceptorTask.java Outdated Show resolved Hide resolved

...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/CountErrorsPerInterceptorTask.java Outdated Show resolved Hide resolved

...able/src/main/java/com/google/cloud/bigtable/data/v2/stub/CountErrorsPerInterceptorTask.java Outdated Show resolved Hide resolved

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved

rkaregar added 2 commits

February 13, 2024 14:08


          Address comments and refactor by defining new classes.

cb29640


          Fix code formatting.

d827cf3

mutianf requested changes

View reviewed changes

...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/ConnectionErrorCountInterceptor.java Outdated Show resolved Hide resolved

...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/ConnectionErrorCountInterceptor.java Outdated Show resolved Hide resolved

...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/ConnectionErrorCountInterceptor.java Outdated Show resolved Hide resolved

...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/ConnectionMetricsTracker.java Outdated Show resolved Hide resolved

...-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/ConnectionMetricsTracker.java Outdated Show resolved Hide resolved

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved

...gtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/ErrorCountPerConnectionTest.java Outdated Show resolved Hide resolved

...gtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/ErrorCountPerConnectionTest.java Outdated Show resolved Hide resolved

...gtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/ErrorCountPerConnectionTest.java Outdated Show resolved Hide resolved

...gtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/ErrorCountPerConnectionTest.java Outdated Show resolved Hide resolved


          Refactor classes and move to better packages.

b5389f0

igorbernstein2 requested changes

View reviewed changes

...ava/com/google/cloud/bigtable/data/v2/stub/metrics/ErrorCountPerConnectionMetricTracker.java Show resolved Hide resolved

...ava/com/google/cloud/bigtable/data/v2/stub/metrics/ErrorCountPerConnectionMetricTracker.java Outdated Show resolved Hide resolved

...rc/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/ErrorCountPerConnectionTest.java Outdated Show resolved Hide resolved


          Clean up classes and address comments.

9248b14

mutianf reviewed

View reviewed changes

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved


          Update the scheduler object.

b5fcd12

igorbernstein2 requested changes

View reviewed changes

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Show resolved Hide resolved

...loud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java Outdated Show resolved Hide resolved

mutianf approved these changes

View reviewed changes

Contributor

mutianf left a comment

lgtm after the final nit

...rc/test/java/com/google/cloud/bigtable/data/v2/stub/metrics/ErrorCountPerConnectionTest.java Outdated Show resolved Hide resolved

rkaregar added 3 commits

February 16, 2024 11:28


          Apply cleanups.

92e6fdf


          Fix unit tests and avoid hanging when getting error in close().

96730e7


          Fix code formatting.

fc67864

igorbernstein2 reviewed

View reviewed changes

...ain/java/com/google/cloud/bigtable/data/v2/stub/metrics/ConnectionErrorCountInterceptor.java Outdated Show resolved Hide resolved

rkaregar added 3 commits

February 16, 2024 13:09


          Improve error handling in the close() method.

26e5a93


          Improve exception logging.

26c165b


          Fix code formatting.

a2e6d18

igorbernstein2 approved these changes

View reviewed changes

mutianf added the owlbot:run label

gcf-owl-bot bot removed the owlbot:run label


          🦉 Updates from OwlBot post-processor

a1d9c77

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

mutianf added the automerge label

mutianf merged commit 7d27816 into googleapis:main

21 checks passed

gcf-merge-on-green bot removed the automerge label

release-please bot mentioned this pull request

chore(main): release 2.34.0 #2118

Merged

gcf-merge-on-green bot pushed a commit that referenced this pull request


          chore(main): release 2.34.0 (#2118)

6e0c070

🤖 I have created a release *beep* *boop*
---


## [2.34.0](https://togithub.com/googleapis/java-bigtable/compare/v2.33.0...v2.34.0) (2024-02-21)


### Features

* Add the export logic for per-connection error rate metric ([#2121](https://togithub.com/googleapis/java-bigtable/issues/2121)) ([d053f2d](https://togithub.com/googleapis/java-bigtable/commit/d053f2dc98eb8576f33471d728c6fbf32d537ece))
* Create the backbone of counting errors per connection each minute. ([#2094](https://togithub.com/googleapis/java-bigtable/issues/2094)) ([7d27816](https://togithub.com/googleapis/java-bigtable/commit/7d27816b959a06412f59f49023611f0bca8e3536))


### Dependencies

* Update actions/setup-java action to v4 ([#2106](https://togithub.com/googleapis/java-bigtable/issues/2106)) ([a694296](https://togithub.com/googleapis/java-bigtable/commit/a694296a76faefe31585aabc9dce0adcf4a342bf))
* Update dependency com.google.cloud:gapic-libraries-bom to v1.30.0 ([#2126](https://togithub.com/googleapis/java-bigtable/issues/2126)) ([f613bd0](https://togithub.com/googleapis/java-bigtable/commit/f613bd0dd449d218a0d8b6d20344155f9762cfb1))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.25.0 ([#2113](https://togithub.com/googleapis/java-bigtable/issues/2113)) ([ba1973e](https://togithub.com/googleapis/java-bigtable/commit/ba1973e20c4cbb9be778840cc202eb7e4daf04f4))
* Update dependency com.google.truth.extensions:truth-proto-extension to v1.4.1 ([#2119](https://togithub.com/googleapis/java-bigtable/issues/2119)) ([0a7ad66](https://togithub.com/googleapis/java-bigtable/commit/0a7ad66fa9e2c1858f51c25d1ea01b26da0b944f))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.10.1 ([#2122](https://togithub.com/googleapis/java-bigtable/issues/2122)) ([99ec284](https://togithub.com/googleapis/java-bigtable/commit/99ec28425c2caac6a992cb7edd83f2029cce92ec))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.1 ([#2123](https://togithub.com/googleapis/java-bigtable/issues/2123)) ([12d961a](https://togithub.com/googleapis/java-bigtable/commit/12d961aad5d15feb27a7996de8b9a626fcdfbc5b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment