Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(fix): Deflake Backup integration tests due to deleteBackup timeouts #2105

Merged
merged 1 commit into from Feb 8, 2024
Merged

test(fix): Deflake Backup integration tests due to deleteBackup timeouts #2105

merged 1 commit into from Feb 8, 2024

Conversation

steveniemitz
Copy link
Contributor

Fixes #2104 ☕️

@steveniemitz steveniemitz requested review from a team as code owners February 8, 2024 14:46
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Feb 8, 2024
igorbernstein2
igorbernstein2 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after nit

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableBackupIT.java Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 8, 2024
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@kolea2 kolea2 changed the title fix: Deflake Backup integration tests due to deleteBackup timeouts test(fix): Deflake Backup integration tests due to deleteBackup timeouts Feb 8, 2024
@igorbernstein2 igorbernstein2 merged commit 0948da7 into googleapis:main Feb 8, 2024
21 checks passed
@release-please release-please bot mentioned this pull request Feb 7, 2024
Merged
@steveniemitz steveniemitz deleted the fix-its branch February 8, 2024 16:52
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 12, 2024
@release-please
chore(main): release 2.33.0 (#2090)
d380d53 
🤖 I have created a release *beep* *boop*
---


## [2.33.0](https://togithub.com/googleapis/java-bigtable/compare/v2.32.0...v2.33.0) (2024-02-12)


### Features

* Define the metrics for collecting per connection error count. ([#2088](https://togithub.com/googleapis/java-bigtable/issues/2088)) ([b212bbf](https://togithub.com/googleapis/java-bigtable/commit/b212bbfcfb2d8c2e2fdc2fc3609976c8a462f677))


### Bug Fixes

* Deflake Backup integration tests due to deleteBackup timeouts ([#2105](https://togithub.com/googleapis/java-bigtable/issues/2105)) ([0948da7](https://togithub.com/googleapis/java-bigtable/commit/0948da7885958556c85ce333cf13b36896ddc154))
* Extend timeouts for deleting snapshots, backups and tables ([#2108](https://togithub.com/googleapis/java-bigtable/issues/2108)) ([df1d307](https://togithub.com/googleapis/java-bigtable/commit/df1d307255abbe77050c2c24f934b13bb82eb212))


### Dependencies

* **autogen:** Set packed = false on field_behavior extension ([#2101](https://togithub.com/googleapis/java-bigtable/issues/2101)) ([7c438c6](https://togithub.com/googleapis/java-bigtable/commit/7c438c603f3893946f73b2d69f2e0901ac9b044a))
* Update actions/setup-java action to v4 ([#2099](https://togithub.com/googleapis/java-bigtable/issues/2099)) ([a6c7c77](https://togithub.com/googleapis/java-bigtable/commit/a6c7c779df39b151202d765728c853a7bdcd3d18))
* Update dependency com.google.cloud:gapic-libraries-bom to v1.29.0 ([#2109](https://togithub.com/googleapis/java-bigtable/issues/2109)) ([ef88519](https://togithub.com/googleapis/java-bigtable/commit/ef8851976898f595f53bbc239d4f1731893d924b))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.24.0 ([#2085](https://togithub.com/googleapis/java-bigtable/issues/2085)) ([3851a5e](https://togithub.com/googleapis/java-bigtable/commit/3851a5e7db5ae3d3c1d29e6f97fc37815c8b70d1))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.10.0 ([#2091](https://togithub.com/googleapis/java-bigtable/issues/2091)) ([2516a09](https://togithub.com/googleapis/java-bigtable/commit/2516a095c8305a4193bbadf6c08395f6d718e1d0))
* Update protobuf to 25.2 in WORKSPACE ([#2086](https://togithub.com/googleapis/java-bigtable/issues/2086)) ([3eafcee](https://togithub.com/googleapis/java-bigtable/commit/3eafcee16f7a5e357fc8617120ee875d32fc415d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backup ITs are very flaky due to deleteBackup timeouts.
2 participants
@steveniemitz @igorbernstein2