Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable hermetic library generation #2234

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

feat: enable hermetic library generation #2234

wants to merge 21 commits into from
+335 −0

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented May 15, 2024 •
edited

This PR showcases the final state of this repo after we enable the hermetic build workflows. The workflows and their implementations will come from the templates in sdk-platform-java (not yet implemented)

Confirmation that it does work

  • I manually ran the update_googleapis_committish job. Success
  • The generated PR successfully processed the committish change and produced source code changes accordingly
  • Resulting example PR in a fork
    • The PR fails because of a java-bigtable-specific issue. This PR should solve it.

What about renovate.json?

This should be manually updated as each repo has different configurations and cannot be dealt with using a single template

Follow ups

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels May 15, 2024
@diegomarquezp diegomarquezp marked this pull request as ready for review May 23, 2024 20:44
@diegomarquezp diegomarquezp requested review from a team as code owners May 23, 2024 20:44
@blakeli0 blakeli0 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diegomarquezp @JoeWang1127 @blakeli0