Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release main #5961

Merged
merged 2 commits into from
May 3, 2023
Merged

chore: release main #5961

merged 2 commits into from
May 3, 2023

Conversation

release-please[bot]
Copy link
Contributor

@release-please release-please bot commented May 1, 2023

馃 I have created a release beep boop

26.14.0

26.14.0 (2023-05-02)

Dependencies

  • update dependency com.google.cloud:first-party-dependencies to v3.8.0 (#5943) (a21b99b)
  • update dependency com.google.cloud:gapic-libraries-bom to v1.10.0 (#5949) (86615dd)
  • update dependency com.google.cloud:google-cloud-bigquery to v2.25.0 (#5958) (1589569)
  • update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v2.36.1 (#5948) (48d7962)
  • update dependency com.google.cloud:google-cloud-bigtable-bom to v2.21.0 (#5953) (4477816)
  • update dependency com.google.cloud:google-cloud-bigtable-bom to v2.22.0 (#5966) (3ebccb6)
  • update dependency com.google.cloud:google-cloud-datastore-bom to v2.14.5 (#5945) (9c88e22)
  • update dependency com.google.cloud:google-cloud-firestore-bom to v3.10.0 (#5965) (3c34d63)
  • update dependency com.google.cloud:google-cloud-firestore-bom to v3.9.6 (#5944) (82a8435)
  • update dependency com.google.cloud:google-cloud-logging-bom to v3.14.9 (#5947) (9f7a645)
  • update dependency com.google.cloud:google-cloud-logging-logback to v0.130.11-alpha (#5954) (4c1e32c)
  • update dependency com.google.cloud:google-cloud-nio to v0.126.14 (#5955) (866a0fe)
  • update dependency com.google.cloud:google-cloud-pubsub-bom to v1.123.11 (#5952) (4a2a6ce)
  • update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.12.4 (#5956) (865229e)
  • update dependency com.google.cloud:google-cloud-spanner-bom to v6.41.0 (#5959) (7c07f17)
  • update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.9.13 (#5957) (bd5c9db)
  • update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.9.14 (#5964) (d36fff1)
  • update dependency com.google.cloud:google-cloud-storage-bom to v2.22.1 (#5946) (c5ed86b)
  • update dependency com.google.googlejavaformat:google-java-format to v1.17.0 (#5963) (6579e69)

This PR was generated with Release Please. See documentation.

@release-please release-please bot requested a review from a team as a code owner May 1, 2023 14:30
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 1, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch 13 times, most recently from 51ef852 to 830f8aa Compare May 1, 2023 14:46
@emmileaf emmileaf added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 1, 2023
@emmileaf
Copy link
Contributor

emmileaf commented May 1, 2023

Adding do not merge to expect google-cloud-bigtable-bom update on top of #5953 (which I will merge in the meanwhile to troubleshoot failing checks).

@release-please release-please bot force-pushed the release-please--branches--main branch from 830f8aa to 3746065 Compare May 1, 2023 16:20
@emmileaf
Copy link
Contributor

emmileaf commented May 1, 2023

Remaining failure in bom-content-test:

[INFO] Running com.google.cloud.BomContentTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 102.817 s <<< FAILURE! - in com.google.cloud.BomContentTest
Error:  com.google.cloud.BomContentTest.testLibrariesBom  Time elapsed: 102.714 s  <<< FAILURE!
java.lang.AssertionError: 
Failing test due to duplicate classes found on classpath:
Duplicate class com.google.api.resourcenames.ResourceName found in classpath. Found in artifacts com.google.api:api-common:2.9.0 and com.google.api:gapic-generator-java:2.18.0.
Duplicate class com.google.api.resourcenames.ResourceNameFactory found in classpath. Found in artifacts com.google.api:api-common:2.9.0 and com.google.api:gapic-generator-java:2.18.0.
...
Duplicate class com.google.gson.JsonDeserializer found in classpath. Found in artifacts com.google.code.gson:gson:2.10.1 and com.google.api:gapic-generator-java:2.18.0.
Duplicate class com.google.gson.JsonStreamParser found in classpath. Found in artifacts com.google.code.gson:gson:2.10.1 and com.google.api:gapic-generator-java:2.18.0.
...
Duplicate class com.google.auto.value.extension.serializable.SerializableAutoValue found in classpath. Found in artifacts com.google.auto.value:auto-value-annotations:1.10.1 and com.google.api:gapic-generator-java:2.18.0.
Duplicate class com.google.auto.value.extension.memoized.Memoized found in classpath. Found in artifacts com.google.auto.value:auto-value-annotations:1.10.1 and com.google.api:gapic-generator-java:2.18.0.
...

I think these are related to the gapic-generator-java module now being included in the gapic-generator-java-bom as of version 2.18.0 (googleapis/sdk-platform-java#1645). All listed conflicts are from the gapic-generator-java jar and some other dependency managed in
https://github.com/googleapis/java-shared-dependencies/blob/main/first-party-dependencies/pom.xml (e.g. gson, auth)

@suztomo Would you have more context on the intention of the assertUniqueClasses check, and whether this is a concern from the changes upstream? I can add an exclusion for the gapic-generator-java jar artifact, but wanted to double check before allow-listing it. (cc/ @meltsufin)

@suztomo
Copy link
Member

suztomo commented May 1, 2023

the intention of the assertUniqueClasses check

To avoid unexpectedly include class files that conflicts the name. Such duplicate classes often cause dependency conflicts. The failure means that you (the user of gapic-generator-java) may hit dependency conflicts someday.

I can add an exclusion for the gapic-generator-java jar artifact

Yes, please. If this is for user-facing library, I would fix the root cause but this artifact is for ourselves. No issue.

@emmileaf
Copy link
Contributor

emmileaf commented May 1, 2023

bom-content-test now passing after adding exclusion in #5962. Thanks @suztomo for the help!

@release-please release-please bot force-pushed the release-please--branches--main branch 2 times, most recently from 7920467 to cb6a4ca Compare May 2, 2023 19:19
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 2, 2023
@release-please release-please bot force-pushed the release-please--branches--main branch from 42920e3 to 14800fb Compare May 2, 2023 19:21
@release-please release-please bot force-pushed the release-please--branches--main branch from 14800fb to 6618311 Compare May 2, 2023 19:21
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels May 2, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 2, 2023
@emmileaf emmileaf removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 3, 2023
@emmileaf emmileaf merged commit addf9f9 into main May 3, 2023
21 checks passed
@emmileaf emmileaf deleted the release-please--branches--main branch May 3, 2023 13:32
@release-please
Copy link
Contributor Author

release-please bot commented May 3, 2023

馃 Release is at https://github.com/googleapis/java-cloud-bom/releases/tag/v26.14.0 馃尰

@release-trigger
Copy link

Triggered job: cloud-devrel/client-libraries/java/java-cloud-bom/release/stage (2023-05-03T13:32:46.763Z)

To trigger again, remove the autorelease: triggered label (in a few minutes).

@release-tool-publish-reporter
Copy link

The release build has started, the log can be viewed here. 馃尰

@release-tool-publish-reporter
Copy link

馃 You hatched a release! The release build finished successfully! 馃挏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: published size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants