Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checksum format #1178

Merged
merged 3 commits into from Sep 13, 2023
Merged

Conversation

nimf
Copy link
Contributor

@nimf nimf commented Aug 28, 2023

Fix checksum format to match the server's format -- unsigned long.

@nimf nimf requested review from a team as code owners August 28, 2023 23:12
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: datastore Issues related to the googleapis/java-datastore API. labels Aug 28, 2023
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@kolea2
Copy link
Collaborator

kolea2 commented Sep 13, 2023

Looks good, however the lint check is failing. @nimf you can run mvn com.coveo:fmt-maven-plugin:format to format the code.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@kolea2 kolea2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner September 13, 2023 18:07
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2023
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 410b939 into googleapis:main Sep 13, 2023
18 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2023
@nimf nimf deleted the fix-checksum-format branch September 13, 2023 21:50
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 27, 2023
🤖 I have created a release *beep* *boop*
---


## [2.17.2](https://togithub.com/googleapis/java-datastore/compare/v2.17.1...v2.17.2) (2023-09-26)


### Bug Fixes

* Checksum format ([#1178](https://togithub.com/googleapis/java-datastore/issues/1178)) ([410b939](https://togithub.com/googleapis/java-datastore/commit/410b9397bb9ba480dff6217c0c4c27364e58db49))
* Deprecate `databaseId` on datastore-v1-proto-client DatastoreOptions ([#1190](https://togithub.com/googleapis/java-datastore/issues/1190)) ([12a3d27](https://togithub.com/googleapis/java-datastore/commit/12a3d27ebc7ca87338ee896fd6ba3e804edd95ce))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.16.0 ([#1195](https://togithub.com/googleapis/java-datastore/issues/1195)) ([6f0cad7](https://togithub.com/googleapis/java-datastore/commit/6f0cad7268cee6347d34125c14c1133b80c840d7))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.16.1 ([#1198](https://togithub.com/googleapis/java-datastore/issues/1198)) ([8062be9](https://togithub.com/googleapis/java-datastore/commit/8062be94b00fe2967e592f3d0a35751f0d11a013))
* Update dependency com.google.errorprone:error_prone_core to v2.22.0 ([#1194](https://togithub.com/googleapis/java-datastore/issues/1194)) ([b8f108a](https://togithub.com/googleapis/java-datastore/commit/b8f108a3d013b5b54c519db24b40dd63e4855240))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.26 ([#1176](https://togithub.com/googleapis/java-datastore/issues/1176)) ([76e3a71](https://togithub.com/googleapis/java-datastore/commit/76e3a71560222894513a485cb91cec7161276e3c))
* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.27 ([#1192](https://togithub.com/googleapis/java-datastore/issues/1192)) ([aa3bca1](https://togithub.com/googleapis/java-datastore/commit/aa3bca10de19350cabc244426ebc284c64cb7344))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.26 ([#1177](https://togithub.com/googleapis/java-datastore/issues/1177)) ([7733004](https://togithub.com/googleapis/java-datastore/commit/7733004aff34bb8b4b8addccc68e75080f0f33a5))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.27 ([#1193](https://togithub.com/googleapis/java-datastore/issues/1193)) ([a628255](https://togithub.com/googleapis/java-datastore/commit/a628255dffc2e8f871df699ebe7a94e4b75eb4b9))
* Update gapic-generator-java to 2.26.0 ([#1197](https://togithub.com/googleapis/java-datastore/issues/1197)) ([2540282](https://togithub.com/googleapis/java-datastore/commit/2540282653d8f8f06a71568c81eca8d3cb70f00f))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants