fix: Remove DocumentReference special case in cursor #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
milaGGL
changed the title
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
milaGGL
changed the title
milaGGL
changed the title
product-auto-label
bot
added
size: m
milaGGL
commented
Oct 5, 2023
| @@ -1143,13 +1140,7 @@ public Query startAt(@Nonnull DocumentSnapshot snapshot) { | |||
| */ | |||
| @Nonnull | |||
| public Query startAt(Object... fieldValues) { | |||
| // TODO(b/296435819): Remove this warning message. | |||
| warningOnSingleDocumentReference(fieldValues); | |||
There was a problem hiding this comment.
remove previously added warning message.
milaGGL
commented
Oct 5, 2023
| // TODO(b/296435819): Remove this warning message. | ||
| warningOnSingleDocumentReference(fieldValues); | ||
|
|
||
| ImmutableList<FieldOrder> fieldOrders = |
There was a problem hiding this comment.
remove the special treatment for DocumentReference type
milaGGL
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
milaGGL
added
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from : googleapis/nodejs-firestore#1882