Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'isTransactional' attribute. #1657

Merged
merged 1 commit into from May 2, 2024
Merged

feat: Add 'isTransactional' attribute. #1657

merged 1 commit into from May 2, 2024

Conversation

ehsannas
Copy link
Contributor

No description provided.

@ehsannas ehsannas requested a review from a team as a code owner April 26, 2024 00:44
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/java-firestore API. labels Apr 26, 2024
@ehsannas ehsannas removed the request for review from a team April 26, 2024 00:45
@jimit-j-shah
Copy link

Did you test this - as in how this shows up in the trace information? Please also update the Trace catalog.

@ehsannas
Copy link
Contributor Author

ehsannas commented May 2, 2024

Did you test this - as in how this shows up in the trace information?

Yes. I also manually tested and observed the attribute in Cloud Trace.

Please also update the Trace catalog

Done

@ehsannas ehsannas merged commit 8981c00 into tracing May 2, 2024
16 checks passed
@ehsannas ehsannas deleted the ehsann/add-attr branch May 2, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants