Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable v2.LogEntry Protobufs converter functions #1509

Merged
merged 3 commits into from Jan 24, 2024

Conversation

cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1298 ☕️

If you write sample code, please follow the samples format.

@cindy-peng cindy-peng requested review from a team as code owners January 17, 2024 17:12
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 17, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jan 17, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 17, 2024
@cindy-peng cindy-peng self-assigned this Jan 17, 2024
@cindy-peng cindy-peng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 17, 2024
@cindy-peng cindy-peng changed the title fix: enable v2.LogEntry Protobufs converter fix: enable v2.LogEntry Protobufs converter functions Jan 17, 2024
@cindy-peng cindy-peng merged commit 9ef4d90 into main Jan 24, 2024
22 checks passed
@cindy-peng cindy-peng deleted the cindy/v2converter branch January 24, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to write v2.LogEntry Protobufs
3 participants