feat: Add Cloud Run Jobs support #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
cindy-peng
force-pushed
the
cindy/cloudrun
branch
from
5f83bd6
to
24b837e
Compare
|
Put this PR on hold due to code freeze. Will resume merging and releasing once feeze is over. |
gkevinzheng
reviewed
Apr 16, 2024
| enhancers.add( | ||
| new LabelLoggingEnhancer( | ||
| CLOUD_RUN_JOB_LABEL_PREFIX, | ||
| ImmutableList.of(Label.CloudRunJobExecutionName, Label.CloudRunJobTaskIndex))); |
There was a problem hiding this comment.
According to this (https://cloud.google.com/logging/docs/api/platform-logs#cloud_run) you're missing a label for task attempt.
There was a problem hiding this comment.
Good catch. Added cloud run task attempt label into enhancer.
…ogging into cindy/cloudrun
|
Merging this PR for now since customers are blocked on this. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 25, 2024
🤖 I have created a release *beep* *boop* --- ## [3.17.0](https://togithub.com/googleapis/java-logging/compare/v3.16.3...v3.17.0) (2024-04-25) ### Features * Add Cloud Run Jobs support ([#1574](https://togithub.com/googleapis/java-logging/issues/1574)) ([1dd64d0](https://togithub.com/googleapis/java-logging/commit/1dd64d078e0d4cbb1e16cb1d050ba192492d6a60)) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.39.0 ([#1587](https://togithub.com/googleapis/java-logging/issues/1587)) ([848418b](https://togithub.com/googleapis/java-logging/commit/848418b426c2e93e636dbd9de71985c386ccb9d2)) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.29.0 ([#1586](https://togithub.com/googleapis/java-logging/issues/1586)) ([edcaf8d](https://togithub.com/googleapis/java-logging/commit/edcaf8de643a7f7f419ee6059c706d0ef0ef4873)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1514 ☕️
If you write sample code, please follow the samples format.