Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removing misspelled field, add correctly spelled field #1011

Merged
merged 3 commits into from Feb 28, 2022
Merged

fix: removing misspelled field, add correctly spelled field #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ec3c54
fix!: removing misspelled field, add correctly spelled field
gcf-owl-bot[bot] Feb 11, 2022
f46a6fc
🦉 Updates from OwlBot
gcf-owl-bot[bot] Feb 11, 2022
a037b05
Merge branch 'main' into owl-bot-copy
suztomo Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SubscriptionAdminClient.java
View file
Open in desktop
Expand Up @@ -488,6 +488,7 @@ public final Subscription createSubscription(
* .setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
* .setRetryPolicy(RetryPolicy.newBuilder().build())
* .setDetached(true)
* .setEnableExactlyOnceDelivery(true)
* .setTopicMessageRetentionDuration(Duration.newBuilder().build())
* .build();
* Subscription response = subscriptionAdminClient.createSubscription(request);
Expand Down Expand Up @@ -743,6 +744,7 @@ public final Subscription createSubscription(
* .setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
* .setRetryPolicy(RetryPolicy.newBuilder().build())
* .setDetached(true)
* .setEnableExactlyOnceDelivery(true)
* .setTopicMessageRetentionDuration(Duration.newBuilder().build())
* .build();
* ApiFuture<Subscription> future =
Expand Down
11 changes: 11 additions & 0 deletions ...le-cloud-pubsub/src/test/java/com/google/cloud/pubsub/v1/SubscriptionAdminClientTest.java
View file
Open in desktop
Expand Up @@ -149,6 +149,7 @@ public void createSubscriptionTest() throws Exception {
.setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
.setRetryPolicy(RetryPolicy.newBuilder().build())
.setDetached(true)
.setEnableExactlyOnceDelivery(true)
.setTopicMessageRetentionDuration(Duration.newBuilder().build())
.build();
mockSubscriber.addResponse(expectedResponse);
Expand Down Expand Up @@ -210,6 +211,7 @@ public void createSubscriptionTest2() throws Exception {
.setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
.setRetryPolicy(RetryPolicy.newBuilder().build())
.setDetached(true)
.setEnableExactlyOnceDelivery(true)
.setTopicMessageRetentionDuration(Duration.newBuilder().build())
.build();
mockSubscriber.addResponse(expectedResponse);
Expand Down Expand Up @@ -271,6 +273,7 @@ public void createSubscriptionTest3() throws Exception {
.setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
.setRetryPolicy(RetryPolicy.newBuilder().build())
.setDetached(true)
.setEnableExactlyOnceDelivery(true)
.setTopicMessageRetentionDuration(Duration.newBuilder().build())
.build();
mockSubscriber.addResponse(expectedResponse);
Expand Down Expand Up @@ -332,6 +335,7 @@ public void createSubscriptionTest4() throws Exception {
.setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
.setRetryPolicy(RetryPolicy.newBuilder().build())
.setDetached(true)
.setEnableExactlyOnceDelivery(true)
.setTopicMessageRetentionDuration(Duration.newBuilder().build())
.build();
mockSubscriber.addResponse(expectedResponse);
Expand Down Expand Up @@ -393,6 +397,7 @@ public void getSubscriptionTest() throws Exception {
.setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
.setRetryPolicy(RetryPolicy.newBuilder().build())
.setDetached(true)
.setEnableExactlyOnceDelivery(true)
.setTopicMessageRetentionDuration(Duration.newBuilder().build())
.build();
mockSubscriber.addResponse(expectedResponse);
Expand Down Expand Up @@ -444,6 +449,7 @@ public void getSubscriptionTest2() throws Exception {
.setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
.setRetryPolicy(RetryPolicy.newBuilder().build())
.setDetached(true)
.setEnableExactlyOnceDelivery(true)
.setTopicMessageRetentionDuration(Duration.newBuilder().build())
.build();
mockSubscriber.addResponse(expectedResponse);
Expand Down Expand Up @@ -495,6 +501,7 @@ public void updateSubscriptionTest() throws Exception {
.setDeadLetterPolicy(DeadLetterPolicy.newBuilder().build())
.setRetryPolicy(RetryPolicy.newBuilder().build())
.setDetached(true)
.setEnableExactlyOnceDelivery(true)
.setTopicMessageRetentionDuration(Duration.newBuilder().build())
.build();
mockSubscriber.addResponse(expectedResponse);
Expand Down Expand Up @@ -1015,6 +1022,10 @@ public void streamingPullTest() throws Exception {
StreamingPullResponse expectedResponse =
StreamingPullResponse.newBuilder()
.addAllReceivedMessages(new ArrayList<ReceivedMessage>())
.setAcknowledgeConfirmation(
StreamingPullResponse.AcknowledgeConfirmation.newBuilder().build())
.setModifyAckDeadlineConfirmation(
StreamingPullResponse.ModifyAckDeadlineConfirmation.newBuilder().build())
.setSubscriptionProperties(
StreamingPullResponse.SubscriptionProperties.newBuilder().build())
.build();
Expand Down