Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated log level from WARNING -> INFO for EOD failures #1218

Merged
merged 3 commits into from Aug 1, 2022
Merged

fix: Updated log level from WARNING -> INFO for EOD failures #1218

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4405678
fix: Updated log level from WARNING -> INFO for EOD failures
mmicatka Aug 1, 2022
6bd42e1
formatting
mmicatka Aug 1, 2022
2caa2de
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java
View file
Open in desktop
Expand Up @@ -547,18 +547,17 @@ public void onFailure(Throwable t) {
String errorMessage = metadataMap.get(ackId);
if (errorMessage.startsWith(TRANSIENT_FAILURE_METADATA_PREFIX)) {
// Retry all "TRANSIENT_*" error messages - do not set message future
logger.log(Level.WARNING, "Transient error message, will resend", errorMessage);
logger.log(Level.INFO, "Transient error message, will resend", errorMessage);
ackRequestDataArrayRetryList.add(ackRequestData);
} else if (errorMessage.equals(PERMANENT_FAILURE_INVALID_ACK_ID_METADATA)) {
// Permanent failure, send
logger.log(
Level.WARNING,
Level.INFO,
"Permanent error invalid ack id message, will not resend",
errorMessage);
ackRequestData.setResponse(AckResponse.INVALID, setResponseOnSuccess);
} else {
logger.log(
Level.WARNING, "Unknown error message, will not resend", errorMessage);
logger.log(Level.INFO, "Unknown error message, will not resend", errorMessage);
ackRequestData.setResponse(AckResponse.OTHER, setResponseOnSuccess);
}
} else {
Expand Down