Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding a GCS subscription example #1762

Merged
merged 17 commits into from
Oct 27, 2023

Conversation

maitrimangal
Copy link
Member

Creating a Cloud Storage Subscription example from Pubsub

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Oct 5, 2023
@snippet-bot
Copy link

snippet-bot bot commented Oct 5, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Oct 5, 2023
@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 5, 2023
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners October 5, 2023 19:23
@lahuang4
Copy link

Can you please update unit tests to test the new sample? You can look at https://github.com/googleapis/java-pubsub/pull/1168/files for inspiration.

@lahuang4 lahuang4 self-requested a review October 11, 2023 18:53
@maitrimangal
Copy link
Member Author

Can you please update unit tests to test the new sample? You can look at https://github.com/googleapis/java-pubsub/pull/1168/files for inspiration.

Testcases will need to be added in a separate PR, because we need to move over our testing env from java-docs-samples-testing to a new env so that we can add the service account needed for this GCS Bucket to the project. Will create a new Issue to address this.

@maitrimangal
Copy link
Member Author

Created issues: #1792 and #1793 to track the test cases.

@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 24, 2023
@maitrimangal maitrimangal added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 26, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 26, 2023
@maitrimangal maitrimangal added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 27, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 27, 2023
@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2023
@maitrimangal maitrimangal merged commit 3ce824c into googleapis:main Oct 27, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants