Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Swap writer and reader schema to correct places in sample #1849

Merged
merged 62 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
3c6897c
samples: schema evolution
kamalaboulhosn Jan 23, 2023
7ea48d9
samples: schema evolution
kamalaboulhosn Jan 23, 2023
3438da5
Merge branch 'googleapis:main' into master
kamalaboulhosn Jan 23, 2023
4e5c026
Format fixes
kamalaboulhosn Jan 23, 2023
032a92f
Merge branch 'master' of https://github.com/kamalaboulhosn/java-pubsub
kamalaboulhosn Jan 23, 2023
8a81408
Fix documentation for field.
kamalaboulhosn Jan 23, 2023
90800ac
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 26, 2023
a88377c
Add back in working asserts
kamalaboulhosn Jan 26, 2023
6a741ea
Merge branch 'master' of https://github.com/kamalaboulhosn/java-pubsub
kamalaboulhosn Jan 26, 2023
9a07bbd
Formatting fixes
kamalaboulhosn Jan 26, 2023
df27d57
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 30, 2023
7d1c561
Version/delete fixes
kamalaboulhosn Feb 14, 2023
d917065
Merge branch 'master' of https://github.com/kamalaboulhosn/java-pubsub
kamalaboulhosn Feb 14, 2023
646afa7
samples: schema evolution
kamalaboulhosn Jan 23, 2023
e0cce5a
samples: schema evolution
kamalaboulhosn Jan 23, 2023
51deeb0
Format fixes
kamalaboulhosn Jan 23, 2023
a53b564
Fix documentation for field.
kamalaboulhosn Jan 23, 2023
f1224e6
Add back in working asserts
kamalaboulhosn Jan 26, 2023
de55b05
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jan 26, 2023
503339f
Formatting fixes
kamalaboulhosn Jan 26, 2023
cbd910c
Version/delete fixes
kamalaboulhosn Feb 14, 2023
7d15680
Merge branch 'master' of https://github.com/kamalaboulhosn/java-pubsub
kamalaboulhosn Feb 23, 2023
1c7e840
samples: Schema evolution (#1499)
kamalaboulhosn Feb 23, 2023
f5d8b39
Merge branch 'googleapis:main' into master
kamalaboulhosn Feb 23, 2023
6195b1c
Minor fixes for comments
kamalaboulhosn Feb 23, 2023
24cc817
Merge branch 'master' of https://github.com/kamalaboulhosn/java-pubsub
kamalaboulhosn Feb 23, 2023
18e9c3b
samples: Schema evolution (#1499)
kamalaboulhosn Feb 23, 2023
37a35cb
Merge branch 'schema-evolution-examples' of https://github.com/google…
kamalaboulhosn Feb 23, 2023
79b0514
Merge branch 'schema-evolution-examples' into master
kamalaboulhosn Feb 23, 2023
b1d2309
Fix rollback example
kamalaboulhosn Mar 10, 2023
3f74191
Formatting
kamalaboulhosn Mar 10, 2023
8b1288a
Formatting and wording fixes
kamalaboulhosn Mar 10, 2023
5057f17
Add new schemas to test directory
kamalaboulhosn Mar 10, 2023
ba38121
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 10, 2023
9dff92e
Samples: Fix exception handling
kamalaboulhosn Mar 11, 2023
30b63a8
Merge branch 'master' of https://github.com/kamalaboulhosn/java-pubsub
kamalaboulhosn Mar 11, 2023
13cbbf9
Merge remote-tracking branch 'upstream/main'
kamalaboulhosn Mar 11, 2023
3185a3e
fix: Set x-goog-request-params for streaming pull request
kamalaboulhosn Mar 14, 2023
3b1f4d9
Revert "fix: Set x-goog-request-params for streaming pull request"
kamalaboulhosn Mar 14, 2023
9c576e8
Revert "Revert "fix: Set x-goog-request-params for streaming pull req…
kamalaboulhosn Mar 14, 2023
f68af6e
Merge remote-tracking branch 'upstream/main'
kamalaboulhosn Mar 14, 2023
817a128
Merge branch 'googleapis:main' into master
kamalaboulhosn Jun 26, 2023
c3a5725
Merge branch 'googleapis:main' into master
kamalaboulhosn Jul 25, 2023
dea5c9c
Thread example
kamalaboulhosn Aug 31, 2023
c58f5a0
Add examples for limited and unlimited exeuctors
kamalaboulhosn Sep 12, 2023
6d8186f
Add back missing semicolon
kamalaboulhosn Sep 12, 2023
307019a
Revert changes to original async example
kamalaboulhosn Sep 12, 2023
aed305a
Revert changes to original async example
kamalaboulhosn Sep 12, 2023
11cddae
Add examples of different threading models
kamalaboulhosn Aug 31, 2023
47328ef
Merge branch 'ML_experiments' of https://github.com/kamalaboulhosn/ja…
kamalaboulhosn Sep 12, 2023
079acc4
Make variables final to conform to style.
kamalaboulhosn Sep 12, 2023
af96f23
Fix catches
kamalaboulhosn Sep 12, 2023
11fda48
Fix ids
kamalaboulhosn Sep 12, 2023
2e58cd5
Fix naming
kamalaboulhosn Sep 12, 2023
5a435fa
Merge pull request #2 from kamalaboulhosn/ML_experiments
kamalaboulhosn Sep 13, 2023
a1394c6
Revert "Merge pull request #2 from kamalaboulhosn/ML_experiments"
kamalaboulhosn Oct 20, 2023
d2f52cf
Set blunderbuss config to auto-assign issues and PRs
kamalaboulhosn Oct 20, 2023
ffccdd3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Oct 23, 2023
f2a4ce6
fix: Swap writer and reader schema to correct places in sample
kamalaboulhosn Dec 14, 2023
b245c1b
Merge branch 'main' of https://github.com/kamalaboulhosn/java-pubsub
kamalaboulhosn Dec 14, 2023
d220539
Merge branch 'main' of https://github.com/kamalaboulhosn/java-pubsub
kamalaboulhosn Dec 14, 2023
f109199
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ If you are using Maven without the BOM, add this to your dependencies:
If you are using Gradle 5.x or later, add this to your dependencies:

```Groovy
implementation platform('com.google.cloud:libraries-bom:26.28.0')
implementation platform('com.google.cloud:libraries-bom:26.29.0')

implementation 'com.google.cloud:google-cloud-pubsub'
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public static void subscribeWithAvroSchemaRevisionsExample(
Schema schema = schemaServiceClient.getSchema(name + "@" + revision);
org.apache.avro.Schema avroSchema =
new org.apache.avro.Schema.Parser().parse(schema.getDefinition());
reader = new SpecificDatumReader<State>(State.getClassSchema(), avroSchema);
reader = new SpecificDatumReader<State>(avroSchema, State.getClassSchema());
synchronized (revisionReaders) {
revisionReaders.put(revision, reader);
}
Expand Down