feat: unload partitions when not publishing for better performance #1286
+252
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: pubsublite
dpcollins-google
force-pushed
the
publisher-stop-partitions
branch
from
e7b4fd3
to
d2bdb77
Compare
tmdiep
reviewed
Dec 8, 2022
| } | ||
| }, | ||
| SystemExecutors.getFuturesExecutor()); | ||
| publisher.get().startAsync().awaitRunning(); |
There was a problem hiding this comment.
Is it ok to block the publish() call here, while the stream is connecting?
In Go, I allowed the wire publisher to accept messages while it is starting up. The messages just get queued until the stream is connected.
There was a problem hiding this comment.
I think this issue already exists- so I'm okay with blocking here. We should as a refactor fix this eventually.
tmdiep
reviewed
Dec 9, 2022
|
|
||
| private synchronized void onUnloadAlarm() { | ||
| if (publisher.isPresent() && !sawPublish) { | ||
| publisher.get().stopAsync().awaitTerminated(); |
There was a problem hiding this comment.
Similar to the above, waiting here may block publish() due to the lock held.
dpcollins-google
force-pushed
the
publisher-stop-partitions
branch
from
5bf88a3
to
7921de9
Compare
dpcollins-google
added
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.