Skip to content

Commit

Permalink
deps: remove specific JDBC version from samples (#1371)
Browse files Browse the repository at this point in the history
- Removes the specific JDBC version from the samples. This is no longer needed, as the BOM now contains a JDBC driver version that is up-to-date enough to work with these samples (they require RETURN_GENERATED_KEYS).
- Adds a GitHub Actions workflow for testing the MyBatis sample.
  • Loading branch information
olavloite committed Sep 27, 2023
1 parent bf64add commit b30e391
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 2 deletions.
30 changes: 30 additions & 0 deletions .github/workflows/spring-data-mybatis-sample.yaml
@@ -0,0 +1,30 @@
# Copyright 2023 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
# Github action job to test core java library features on
# downstream client libraries before they are released.
on:
pull_request:
name: spring-data-mybatis-sample
jobs:
spring-data-jdbc:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: temurin
java-version: 17
- name: Run tests
run: mvn test
working-directory: samples/spring-data-mybatis
1 change: 0 additions & 1 deletion samples/spring-data-jdbc/pom.xml
Expand Up @@ -48,7 +48,6 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-spanner-jdbc</artifactId>
<version>2.13.2</version>
</dependency>
<dependency>
<groupId>org.postgresql</groupId>
Expand Down
1 change: 0 additions & 1 deletion samples/spring-data-mybatis/pom.xml
Expand Up @@ -58,7 +58,6 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-spanner-jdbc</artifactId>
<version>2.13.2</version>
</dependency>
<dependency>
<groupId>org.postgresql</groupId>
Expand Down

0 comments on commit b30e391

Please sign in to comment.