Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support untyped NULL value parameters #1224

Merged
merged 6 commits into from
Jun 8, 2023
Merged

feat: support untyped NULL value parameters #1224

merged 6 commits into from
Jun 8, 2023

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented May 10, 2023 •
edited

Support untyped null parameter values for PreparedStatement. This will allow users to add null values as a statement parameter value without having to know what type the column that the parameter is bound to uses.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels May 10, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 2, 2023
@olavloite olavloite marked this pull request as ready for review June 2, 2023 13:23
@olavloite olavloite requested review from a team as code owners June 2, 2023 13:23
@harshachinta harshachinta mentioned this pull request Jun 7, 2023
Merged
rajatbhatta
rajatbhatta reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON and JSONB are nullable. But I see that the setNullValue() method does not cover JSON and JSONB data types (JsonType.VENDOR_TYPE_NUMBER and PgJsonbType.VENDOR_TYPE_NUMBER are missing from switch case). Can we add these too and verify once if all supported data types are included in the switch case so we do not miss out on any case? Let me know if we should do this as a separate exercise.

@olavloite
Copy link
Collaborator Author

JSON and JSONB are nullable. But I see that the setNullValue() method does not cover JSON and JSONB data types (JsonType.VENDOR_TYPE_NUMBER and PgJsonbType.VENDOR_TYPE_NUMBER are missing from switch case). Can we add these too and verify once if all supported data types are included in the switch case so we do not miss out on any case? Let me know if we should do this as a separate exercise.

Good point, I've added those to the switch case as well.

rajatbhatta
rajatbhatta approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

harshachinta
harshachinta approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olavloite olavloite merged commit 80d2b9d into main Jun 8, 2023
21 checks passed
@olavloite olavloite deleted the support-untyped-null-value-params branch June 8, 2023 06:16
@olavloite olavloite mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Jun 12, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 12, 2023
@release-please
chore(main): release 2.11.0 (#1256)
cf417c1 
🤖 I have created a release *beep* *boop*
---


## [2.11.0](https://togithub.com/googleapis/java-spanner-jdbc/compare/v2.10.0...v2.11.0) (2023-06-12)


### Features

* Support untyped NULL value parameters ([#1224](https://togithub.com/googleapis/java-spanner-jdbc/issues/1224)) ([80d2b9d](https://togithub.com/googleapis/java-spanner-jdbc/commit/80d2b9d3e4c3265522bbb20766bff1f164617711))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.11.0 ([#1254](https://togithub.com/googleapis/java-spanner-jdbc/issues/1254)) ([41f40fc](https://togithub.com/googleapis/java-spanner-jdbc/commit/41f40fce634cea205d5e5a9c1eb567ecb97ff655))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.42.3 ([#1248](https://togithub.com/googleapis/java-spanner-jdbc/issues/1248)) ([397d573](https://togithub.com/googleapis/java-spanner-jdbc/commit/397d5738a8126aaf090d533d0f20efb74a77a788))
* Update dependency com.google.cloud:google-cloud-spanner-bom to v6.43.0 ([#1255](https://togithub.com/googleapis/java-spanner-jdbc/issues/1255)) ([ffe36b6](https://togithub.com/googleapis/java-spanner-jdbc/commit/ffe36b6b2087157c8d895fa348cff614435a4735))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta approved these changes

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olavloite @harshachinta @rajatbhatta